From: Benjamin Block <bblock@linux.ibm.com>
To: Muneendra <muneendra.kumar@broadcom.com>
Cc: linux-scsi@vger.kernel.org, hare@suse.de, jsmart2021@gmail.com,
emilne@redhat.com, mkumar@redhat.com,
Steffen Maier <maier@linux.ibm.com>
Subject: Re: [PATCH v3 16/17] scsi:zfcp: Added changes to fc_remote_port_chkready
Date: Thu, 22 Oct 2020 18:50:06 +0200 [thread overview]
Message-ID: <20201022165006.GA15064@t480-pf1aa2c2> (raw)
In-Reply-To: <1602732462-10443-17-git-send-email-muneendra.kumar@broadcom.com>
Would be good if you could address the driver mails to the driver
maintainers :) I was out of office, but we might still miss it
occasionally.
On Thu, Oct 15, 2020 at 08:57:41AM +0530, Muneendra wrote:
> Added changes to pass a new argument to fc_remote_port_chkready
>
> Signed-off-by: Muneendra <muneendra.kumar@broadcom.com>
>
> ---
> v3:
> New Patch
> ---
> drivers/s390/scsi/zfcp_scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c
> index d58bf79892f2..732e15e3a839 100644
> --- a/drivers/s390/scsi/zfcp_scsi.c
> +++ b/drivers/s390/scsi/zfcp_scsi.c
> @@ -74,7 +74,7 @@ int zfcp_scsi_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *scpnt)
> scpnt->result = 0;
> scpnt->host_scribble = NULL;
>
> - scsi_result = fc_remote_port_chkready(rport);
> + scsi_result = fc_remote_port_chkready(rport, scpnt);
> if (unlikely(scsi_result)) {
> scpnt->result = scsi_result;
> zfcp_dbf_scsi_fail_send(scpnt);
> --
> 2.26.2
>
This change looks fine to me for zfcp.
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
next prev parent reply other threads:[~2020-10-22 16:50 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 3:27 [PATCH v3 00/17] scsi: Support to handle Intermittent errors Muneendra
2020-10-15 3:27 ` [PATCH v3 01/17] scsi: Added a new definition in scsi_cmnd.h Muneendra
2020-10-15 3:27 ` [PATCH v3 02/17] scsi: Added a new error code in scsi.h Muneendra
2020-10-15 3:27 ` [PATCH v3 03/17] scsi: No retries on abort success Muneendra
2020-10-16 18:37 ` Mike Christie
2020-10-19 19:05 ` Mike Christie
2020-10-19 19:26 ` Muneendra Kumar M
2020-10-20 19:53 ` Mike Christie
2020-10-20 20:18 ` Mike Christie
2020-10-21 18:51 ` Muneendra Kumar M
2020-10-15 3:27 ` [PATCH v3 04/17] scsi: Added routine to set/clear SCMD_NORETRIES_ABORT bit for outstanding io on scsi_dev Muneendra
2020-10-15 3:27 ` [PATCH v3 05/17] scsi_transport_fc: Added a new rport state FC_PORTSTATE_MARGINAL Muneendra
2020-10-16 19:52 ` Mike Christie
2020-10-19 10:47 ` Muneendra Kumar M
2020-10-19 16:10 ` Michael Christie
2020-10-19 16:19 ` Michael Christie
2020-10-19 17:16 ` Hannes Reinecke
2020-10-19 17:31 ` Muneendra Kumar M
2020-10-19 18:55 ` Mike Christie
2020-10-19 19:03 ` Muneendra Kumar M
2020-10-20 18:24 ` Benjamin Marzinski
2020-10-20 6:03 ` Hannes Reinecke
2020-10-19 18:03 ` Muneendra Kumar M
2020-10-19 18:44 ` Mike Christie
2020-10-19 18:55 ` Muneendra Kumar M
2020-10-20 16:48 ` Mike Christie
2020-10-20 17:19 ` Muneendra Kumar M
2020-10-20 18:44 ` Benjamin Marzinski
2020-10-20 18:14 ` Benjamin Marzinski
2020-10-15 3:27 ` [PATCH v3 06/17] scsi_transport_fc: Added store fucntionality to set the rport port_state using sysfs Muneendra
2020-10-15 14:05 ` kernel test robot
2020-10-16 18:34 ` Mike Christie
2020-10-19 10:52 ` Muneendra Kumar M
2020-10-15 3:27 ` [PATCH v3 07/17] scsi:lpfc: Added changes to fc_remote_port_chkready Muneendra
2020-10-15 3:27 ` [PATCH v3 08/17] scsi:qla2xx: " Muneendra
2020-10-15 3:27 ` [PATCH v3 09/17] scsi:qedf: " Muneendra
2020-10-15 3:27 ` [PATCH v3 10/17] scsi:libfc: " Muneendra
2020-10-15 3:27 ` [PATCH v3 11/17] scsi:ibmvfc: " Muneendra
2020-10-15 3:27 ` [PATCH v3 12/17] scsi:fnic: " Muneendra
2020-10-15 3:27 ` [PATCH v3 13/17] scsi:bnx2fc: " Muneendra
2020-10-15 3:27 ` [PATCH v3 14/17] scsi:csio: " Muneendra
2020-10-15 3:27 ` [PATCH v3 15/17] scsi:bfa: " Muneendra
2020-10-15 3:27 ` [PATCH v3 16/17] scsi:zfcp: " Muneendra
2020-10-22 16:50 ` Benjamin Block [this message]
2020-10-15 3:27 ` [PATCH v3 17/17] scsi:mpt: " Muneendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022165006.GA15064@t480-pf1aa2c2 \
--to=bblock@linux.ibm.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox