Re: [PATCH V4 05/12] sbitmap: export sbitmap_weight

John Garry
2020-11-17T09:19:25Z

On 16/11/2020 09:07, Ming Lei wrote:
> +
> +/**
> + * sbitmap_weight() - Return how many real bits set in a &struct sbitmap.
> + * @sb: Bitmap to check.
> + *
> + * Return: How many real bits set
> + */
> +unsigned int sbitmap_weight(const struct sbitmap *sb);
> +

Hi Ming,

Just a nit on the comment - I think that "real bits set" is vague. How
about "set and not cleared bits", "busy bits", "net set bits" or
"aggregate bits set"?

Thanks,
John