Re: [PATCH v2 4/9] scsi: Rework scsi_mq_alloc_queue()

Christoph Hellwig
2020-11-16T17:18:12Z

On Sun, Nov 15, 2020 at 07:04:54PM -0800, Bart Van Assche wrote:
> Do not modify sdev->request_queue. Remove the sdev->request_queue
> assignment. That assignment is superfluous because scsi_mq_alloc_queue()
> only has one caller and that caller calls scsi_mq_alloc_queue() as follows:
>
> sdev->request_queue = scsi_mq_alloc_queue(sdev);

This looks ok to me. But is there any good to keep scsi_mq_alloc_queue
around at all? It is so trivial that it can be open coded in the
currently only caller, as well as a new one if added.