Re: [PATCH V4 12/12] scsi: replace sdev->device_busy with sbitmap

kernel test robot
2020-11-16T12:38:15Z

[-- Attachment #1: Type: text/plain, Size: 4845 bytes --]

Hi Ming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on block/for-next]
[also build test ERROR on mkp-scsi/for-next scsi/for-next v5.10-rc4 next-20201116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20201116-171449
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: powerpc64-randconfig-r026-20201116 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/cc286ae987be50d7b8e152cc80a5ccaa8682e3ff
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20201116-171449
git checkout cc286ae987be50d7b8e152cc80a5ccaa8682e3ff
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/scsi/megaraid/megaraid_sas_fusion.c:365:41: error: no member named 'device_busy' in 'struct scsi_device'
sdev_busy = atomic_read(&scmd->device->device_busy);
~~~~~~~~~~~~ ^
1 error generated.

vim +365 drivers/scsi/megaraid/megaraid_sas_fusion.c

4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 353
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 354 static inline void
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 355 megasas_get_msix_index(struct megasas_instance *instance,
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 356 struct scsi_cmnd *scmd,
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 357 struct megasas_cmd_fusion *cmd,
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 358 u8 data_arms)
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 359 {
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 360 int sdev_busy;
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 361
103fbf8e4020845 Kashyap Desai 2020-08-19 362 /* TBD - if sml remove device_busy in future, driver
103fbf8e4020845 Kashyap Desai 2020-08-19 363 * should track counter in internal structure.
103fbf8e4020845 Kashyap Desai 2020-08-19 364 */
103fbf8e4020845 Kashyap Desai 2020-08-19 @365 sdev_busy = atomic_read(&scmd->device->device_busy);
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 366
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 367 if (instance->perf_mode == MR_BALANCED_PERF_MODE &&
103fbf8e4020845 Kashyap Desai 2020-08-19 368 sdev_busy > (data_arms * MR_DEVICE_HIGH_IOPS_DEPTH)) {
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 369 cmd->request_desc->SCSIIO.MSIxIndex =
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 370 mega_mod64((atomic64_add_return(1, &instance->high_iops_outstanding) /
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 371 MR_HIGH_IOPS_BATCH_COUNT), instance->low_latency_index_start);
103fbf8e4020845 Kashyap Desai 2020-08-19 372 } else if (instance->msix_load_balance) {
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 373 cmd->request_desc->SCSIIO.MSIxIndex =
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 374 (mega_mod64(atomic64_add_return(1, &instance->total_io_count),
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 375 instance->msix_vectors));
103fbf8e4020845 Kashyap Desai 2020-08-19 376 } else if (instance->host->nr_hw_queues > 1) {
103fbf8e4020845 Kashyap Desai 2020-08-19 377 u32 tag = blk_mq_unique_tag(scmd->request);
103fbf8e4020845 Kashyap Desai 2020-08-19 378
103fbf8e4020845 Kashyap Desai 2020-08-19 379 cmd->request_desc->SCSIIO.MSIxIndex = blk_mq_unique_tag_to_hwq(tag) +
103fbf8e4020845 Kashyap Desai 2020-08-19 380 instance->low_latency_index_start;
103fbf8e4020845 Kashyap Desai 2020-08-19 381 } else {
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 382 cmd->request_desc->SCSIIO.MSIxIndex =
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 383 instance->reply_map[raw_smp_processor_id()];
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 384 }
103fbf8e4020845 Kashyap Desai 2020-08-19 385 }
4d1634b8d12ecb8 Anand Lodnoor 2020-01-14 386

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33994 bytes --]