public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kashyap Desai <kashyap.desai@broadcom.com>, linux-scsi@vger.kernel.org
Cc: kbuild-all@lists.01.org,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	sumit.saxena@broadcom.com, chandrakanth.patil@broadcom.com,
	linux-block@vger.kernel.org
Subject: Re: [PATCH v2 2/4] megaraid_sas: iouring iopoll support
Date: Thu, 3 Dec 2020 21:23:40 +0800	[thread overview]
Message-ID: <202012032143.Qib7ifvG-lkp@intel.com> (raw)
In-Reply-To: <20201203034100.29716-3-kashyap.desai@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 2238 bytes --]

Hi Kashyap,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 0eedceafd3a63fd082743c914853ef4b9247dbe6]

url:    https://github.com/0day-ci/linux/commits/Kashyap-Desai/io_uring-iopoll-in-scsi-layer/20201203-194918
base:    0eedceafd3a63fd082743c914853ef4b9247dbe6
config: i386-randconfig-s001-20201203 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-179-ga00755aa-dirty
        # https://github.com/0day-ci/linux/commit/f2b4b005fc618696e1b343f91cf9907427e0df91
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kashyap-Desai/io_uring-iopoll-in-scsi-layer/20201203-194918
        git checkout f2b4b005fc618696e1b343f91cf9907427e0df91
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/megaraid/megaraid_sas_fusion.c:3652:5: warning: no previous prototype for 'megasas_blk_mq_poll' [-Wmissing-prototypes]
    3652 | int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
         |     ^~~~~~~~~~~~~~~~~~~

vim +/megasas_blk_mq_poll +3652 drivers/scsi/megaraid/megaraid_sas_fusion.c

  3651	
> 3652	int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
  3653	{
  3654	
  3655		struct megasas_instance *instance;
  3656		int num_entries = 0;
  3657		struct fusion_context *fusion;
  3658	
  3659		instance = (struct megasas_instance *)shost->hostdata;
  3660	
  3661		fusion = instance->ctrl_context;
  3662	
  3663		queue_num = queue_num + instance->low_latency_index_start;
  3664	
  3665		if (!atomic_add_unless(&fusion->busy_mq_poll[queue_num], 1, 1))
  3666			return 0;
  3667	
  3668		num_entries = complete_cmd_fusion(instance, queue_num, NULL);
  3669		atomic_dec(&fusion->busy_mq_poll[queue_num]);
  3670	
  3671		return num_entries;
  3672	}
  3673	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32099 bytes --]

  parent reply	other threads:[~2020-12-03 13:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03  3:40 [PATCH v2 0/4] io_uring iopoll in scsi layer Kashyap Desai
2020-12-03  3:40 ` [PATCH v2 1/4] add io_uring with IOPOLL support " Kashyap Desai
2020-12-03 12:51   ` Hannes Reinecke
2020-12-04  8:53   ` John Garry
2020-12-03  3:40 ` [PATCH v2 2/4] megaraid_sas: iouring iopoll support Kashyap Desai
2020-12-03 12:57   ` Hannes Reinecke
2021-02-01 13:55     ` Kashyap Desai
2020-12-03 13:23   ` kernel test robot [this message]
2020-12-03  3:40 ` [PATCH v2 3/4] scsi_debug : " Kashyap Desai
2020-12-03 12:58   ` Hannes Reinecke
2020-12-03 19:09   ` Douglas Gilbert
2020-12-03  3:41 ` [PATCH v2 4/4] scsi: set shost as hctx driver_data Kashyap Desai
2020-12-03 13:26   ` John Garry
2020-12-03 13:30     ` Kashyap Desai
2020-12-04  9:00       ` John Garry
2021-01-11 12:15 ` [PATCH v2 0/4] io_uring iopoll in scsi layer Kashyap Desai
2021-01-13  3:55   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202012032143.Qib7ifvG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=chandrakanth.patil@broadcom.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sumit.saxena@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox