Re: [PATCH 17/24] mpi3mr: add support of threaded isr

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3335 bytes --]

Hi Kashyap,

I love your patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next v5.10 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kashyap-Desai/Introducing-mpi3mr-driver/20201222-181732
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/877f4e22deefcac84c14ed953f360f8131e02d14
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kashyap-Desai/Introducing-mpi3mr-driver/20201222-181732
        git checkout 877f4e22deefcac84c14ed953f360f8131e02d14
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/mpi3mr/mpi3mr_fw.c: In function 'mpi3mr_isr_poll':
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:481:6: warning: variable 'num_admin_replies' set but not used [-Wunused-but-set-variable]
     481 |  u32 num_admin_replies = 0, num_op_reply = 0;
         |      ^~~~~~~~~~~~~~~~~


vim +/num_admin_replies +481 drivers/scsi/mpi3mr/mpi3mr_fw.c

   465	
   466	/**
   467	 * mpi3mr_isr_poll - Reply queue polling routine
   468	 * @irq: IRQ
   469	 * @privdata: Interrupt info
   470	 *
   471	 * poll for pending I/O completions in a loop until pending I/Os
   472	 * present or controller queue depth I/Os are processed.
   473	 *
   474	 * Return: IRQ_NONE or IRQ_HANDLED
   475	 */
   476	static irqreturn_t mpi3mr_isr_poll(int irq, void *privdata)
   477	{
   478		struct mpi3mr_intr_info *intr_info = privdata;
   479		struct mpi3mr_ioc *mrioc;
   480		u16 midx;
 > 481		u32 num_admin_replies = 0, num_op_reply = 0;
   482	
   483		if (!intr_info || !intr_info->op_reply_q)
   484			return IRQ_NONE;
   485	
   486		mrioc = intr_info->mrioc;
   487		midx = intr_info->msix_index;
   488	
   489		/* Poll for pending IOs completions */
   490		do {
   491			if (!mrioc->intr_enabled)
   492				break;
   493	
   494			if (!midx)
   495				num_admin_replies = mpi3mr_process_admin_reply_q(mrioc);
   496			if (intr_info->op_reply_q)
   497				num_op_reply +=
   498				    mpi3mr_process_op_reply_q(mrioc, intr_info);
   499	
   500			usleep_range(mrioc->irqpoll_sleep, 10 * mrioc->irqpoll_sleep);
   501	
   502		} while (atomic_read(&intr_info->op_reply_q->pend_ios) &&
   503		    (num_op_reply < mrioc->max_host_ios));
   504	
   505		intr_info->op_reply_q->enable_irq_poll = false;
   506		enable_irq(pci_irq_vector(mrioc->pdev, midx));
   507	
   508		return IRQ_HANDLED;
   509	}
   510	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71613 bytes --]