Re: [PATCH V6 02/13] sbitmap: maintain allocation round_robin in sbitmap

kernel test robot
2021-01-18T04:43:53Z

[-- Attachment #1: Type: text/plain, Size: 6849 bytes --]

Hi Ming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next v5.11-rc4 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20210118-085444
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-randconfig-r001-20210118 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 95d146182fdf2315e74943b93fb3bb0cbafc5d89)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/0day-ci/linux/commit/16943bc0fa2683fd8d8554745fffe62394a42ec9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20210118-085444
git checkout 16943bc0fa2683fd8d8554745fffe62394a42ec9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/vhost/scsi.c:617:40: error: too many arguments to function call, expected 2, have 3
tag = sbitmap_get(&svq->scsi_tags, 0, false);
~~~~~~~~~~~ ^~~~~
include/linux/sbitmap.h:185:5: note: 'sbitmap_get' declared here
int sbitmap_get(struct sbitmap *sb, unsigned int alloc_hint);
^
>> drivers/vhost/scsi.c:1515:22: error: too few arguments to function call, expected 6, have 5
NUMA_NO_NODE))
^
include/linux/sbitmap.h:153:5: note: 'sbitmap_init_node' declared here
int sbitmap_init_node(struct sbitmap *sb, unsigned int depth, int shift,
^
2 errors generated.

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for HOTPLUG_CPU
Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE
Selected by
- PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP

vim +1515 drivers/vhost/scsi.c

25b98b64e28423b0 Mike Christie 2020-11-09 1503
25b98b64e28423b0 Mike Christie 2020-11-09 1504 static int vhost_scsi_setup_vq_cmds(struct vhost_virtqueue *vq, int max_cmds)
25b98b64e28423b0 Mike Christie 2020-11-09 1505 {
25b98b64e28423b0 Mike Christie 2020-11-09 1506 struct vhost_scsi_virtqueue *svq = container_of(vq,
25b98b64e28423b0 Mike Christie 2020-11-09 1507 struct vhost_scsi_virtqueue, vq);
25b98b64e28423b0 Mike Christie 2020-11-09 1508 struct vhost_scsi_cmd *tv_cmd;
25b98b64e28423b0 Mike Christie 2020-11-09 1509 unsigned int i;
25b98b64e28423b0 Mike Christie 2020-11-09 1510
25b98b64e28423b0 Mike Christie 2020-11-09 1511 if (svq->scsi_cmds)
25b98b64e28423b0 Mike Christie 2020-11-09 1512 return 0;
25b98b64e28423b0 Mike Christie 2020-11-09 1513
25b98b64e28423b0 Mike Christie 2020-11-09 1514 if (sbitmap_init_node(&svq->scsi_tags, max_cmds, -1, GFP_KERNEL,
25b98b64e28423b0 Mike Christie 2020-11-09 @1515 NUMA_NO_NODE))
25b98b64e28423b0 Mike Christie 2020-11-09 1516 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1517 svq->max_cmds = max_cmds;
25b98b64e28423b0 Mike Christie 2020-11-09 1518
25b98b64e28423b0 Mike Christie 2020-11-09 1519 svq->scsi_cmds = kcalloc(max_cmds, sizeof(*tv_cmd), GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1520 if (!svq->scsi_cmds) {
25b98b64e28423b0 Mike Christie 2020-11-09 1521 sbitmap_free(&svq->scsi_tags);
25b98b64e28423b0 Mike Christie 2020-11-09 1522 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1523 }
25b98b64e28423b0 Mike Christie 2020-11-09 1524
25b98b64e28423b0 Mike Christie 2020-11-09 1525 for (i = 0; i < max_cmds; i++) {
25b98b64e28423b0 Mike Christie 2020-11-09 1526 tv_cmd = &svq->scsi_cmds[i];
25b98b64e28423b0 Mike Christie 2020-11-09 1527
25b98b64e28423b0 Mike Christie 2020-11-09 1528 tv_cmd->tvc_sgl = kcalloc(VHOST_SCSI_PREALLOC_SGLS,
25b98b64e28423b0 Mike Christie 2020-11-09 1529 sizeof(struct scatterlist),
25b98b64e28423b0 Mike Christie 2020-11-09 1530 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1531 if (!tv_cmd->tvc_sgl) {
25b98b64e28423b0 Mike Christie 2020-11-09 1532 pr_err("Unable to allocate tv_cmd->tvc_sgl\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1533 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1534 }
25b98b64e28423b0 Mike Christie 2020-11-09 1535
25b98b64e28423b0 Mike Christie 2020-11-09 1536 tv_cmd->tvc_upages = kcalloc(VHOST_SCSI_PREALLOC_UPAGES,
25b98b64e28423b0 Mike Christie 2020-11-09 1537 sizeof(struct page *),
25b98b64e28423b0 Mike Christie 2020-11-09 1538 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1539 if (!tv_cmd->tvc_upages) {
25b98b64e28423b0 Mike Christie 2020-11-09 1540 pr_err("Unable to allocate tv_cmd->tvc_upages\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1541 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1542 }
25b98b64e28423b0 Mike Christie 2020-11-09 1543
25b98b64e28423b0 Mike Christie 2020-11-09 1544 tv_cmd->tvc_prot_sgl = kcalloc(VHOST_SCSI_PREALLOC_PROT_SGLS,
25b98b64e28423b0 Mike Christie 2020-11-09 1545 sizeof(struct scatterlist),
25b98b64e28423b0 Mike Christie 2020-11-09 1546 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1547 if (!tv_cmd->tvc_prot_sgl) {
25b98b64e28423b0 Mike Christie 2020-11-09 1548 pr_err("Unable to allocate tv_cmd->tvc_prot_sgl\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1549 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1550 }
25b98b64e28423b0 Mike Christie 2020-11-09 1551 }
25b98b64e28423b0 Mike Christie 2020-11-09 1552 return 0;
25b98b64e28423b0 Mike Christie 2020-11-09 1553 out:
25b98b64e28423b0 Mike Christie 2020-11-09 1554 vhost_scsi_destroy_vq_cmds(vq);
25b98b64e28423b0 Mike Christie 2020-11-09 1555 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1556 }
25b98b64e28423b0 Mike Christie 2020-11-09 1557

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44539 bytes --]