From: "Michael S. Tsirkin" <mst@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, jasowang@redhat.com,
stefanha@redhat.com, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 05/11] vhost scsi: use lio wq cmd submission helper
Date: Fri, 5 Feb 2021 11:17:19 -0500 [thread overview]
Message-ID: <20210205111638-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210204113513.93204-6-michael.christie@oracle.com>
On Thu, Feb 04, 2021 at 05:35:07AM -0600, Mike Christie wrote:
> @@ -1132,14 +1127,8 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq)
> * vhost_scsi_queue_data_in() and vhost_scsi_queue_status()
> */
> cmd->tvc_vq_desc = vc.head;
> - /*
> - * Dispatch cmd descriptor for cmwq execution in process
> - * context provided by vhost_scsi_workqueue. This also ensures
> - * cmd is executed on the same kworker CPU as this vhost
> - * thread to gain positive L2 cache locality effects.
> - */
> - INIT_WORK(&cmd->work, vhost_scsi_submission_work);
> - queue_work(vhost_scsi_workqueue, &cmd->work);
> + target_queue_cmd_submit(tpg->tpg_nexus->tvn_se_sess,
> + &cmd->tvc_se_cmd);
> ret = 0;
> err:
> /*
What about this aspect? Will things still stay on the same CPU?
--
MST
next prev parent reply other threads:[~2021-02-05 22:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 11:35 [PATCH 00/11] target: fix cmd plugging and completion Mike Christie
2021-02-04 11:35 ` [PATCH 01/11] target: pass in fabric ops to session creation Mike Christie
2021-02-04 11:35 ` [PATCH 02/11] target: add workqueue cmd submission helper Mike Christie
2021-02-04 23:13 ` Chaitanya Kulkarni
2021-02-05 0:43 ` michael.christie
2021-02-05 1:50 ` Chaitanya Kulkarni
2021-02-04 11:35 ` [PATCH 03/11] tcm loop: use blk cmd allocator for se_cmds Mike Christie
2021-02-04 11:35 ` [PATCH 04/11] tcm loop: use lio wq cmd submission helper Mike Christie
2021-02-04 11:35 ` [PATCH 05/11] vhost scsi: " Mike Christie
2021-02-05 16:17 ` Michael S. Tsirkin [this message]
2021-02-05 17:38 ` Mike Christie
2021-02-05 18:04 ` Mike Christie
2021-02-04 11:35 ` [PATCH 06/11] target: cleanup cmd flag bits Mike Christie
2021-02-04 23:15 ` Chaitanya Kulkarni
2021-02-04 11:35 ` [PATCH 07/11] target: fix backend plugging Mike Christie
2021-02-04 11:35 ` [PATCH 08/11] target iblock: add backend plug/unplug callouts Mike Christie
2021-02-04 23:23 ` Chaitanya Kulkarni
2021-02-05 0:45 ` michael.christie
2021-02-07 1:06 ` Chaitanya Kulkarni
2021-02-07 2:21 ` Bart Van Assche
2021-02-04 11:35 ` [PATCH 09/11] target_core_user: " Mike Christie
2021-02-04 23:25 ` Chaitanya Kulkarni
2021-02-07 21:37 ` Mike Christie
2021-02-04 11:35 ` [PATCH 10/11] target: replace work per cmd in completion path Mike Christie
2021-02-04 23:26 ` Chaitanya Kulkarni
2021-02-04 11:35 ` [PATCH 11/11] target, vhost-scsi: don't switch cpus on completion Mike Christie
2021-02-08 10:48 ` [PATCH 00/11] target: fix cmd plugging and completion Stefan Hajnoczi
2021-02-08 12:01 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205111638-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox