From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, chriscjsus@yahoo.com,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] scsi/sd: Fix Opal support
Date: Sun, 21 Feb 2021 09:15:23 +0100 [thread overview]
Message-ID: <20210221081523.GA2639@lst.de> (raw)
In-Reply-To: <20210220173931.22155-1-bvanassche@acm.org>
> - ret = scsi_execute_req(sdev, cdb,
> - send ? DMA_TO_DEVICE : DMA_FROM_DEVICE,
> - buffer, len, NULL, SD_TIMEOUT, sdkp->max_retries, NULL);
> + ret = scsi_execute(sdev, cdb,
> + send ? DMA_TO_DEVICE : DMA_FROM_DEVICE, buffer, len,
> + /*sense=*/NULL, /*sshdr=*/NULL, SD_TIMEOUT, sdkp->max_retries,
> + /*flags=*/0, /*rq_flags=*/RQF_PM, /*resid=*/NULL);
Please keep the existing style here. Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2021-02-21 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 17:39 [PATCH] scsi/sd: Fix Opal support Bart Van Assche
2021-02-21 8:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221081523.GA2639@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chriscjsus@yahoo.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox