From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-ide@vger.kernel.org, linux-mmc@vger.kernel.org,
target-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-block@vger.kernel.org, dm-devel@redhat.com,
fujita.tomonori@lab.ntt.co.jp, tim@cyberelk.net, mst@redhat.com,
jasowang@redhat.com, pbonzini@redhat.com, davem@davemloft.net,
bp@alien8.de, agk@redhat.com, snitzer@redhat.com,
ulf.hansson@linaro.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, dgilbert@interlog.com,
Kai.Makisara@kolumbus.fi, alim.akhtar@samsung.com,
avri.altman@wdc.com, bfields@fieldses.org,
chuck.lever@oracle.com, baolin.wang@linaro.org,
vbadigan@codeaurora.org, zliua@micron.com, richard.peng@oppo.com,
guoqing.jiang@cloud.ionos.com, stanley.chu@mediatek.com,
cang@codeaurora.org, asutoshd@codeaurora.org, beanhuo@micron.com,
jaegeuk@kernel.org
Subject: Re: [RFC PATCH] blk-core: remove blk_put_request()
Date: Wed, 24 Feb 2021 18:55:21 +0000 [thread overview]
Message-ID: <20210224185521.GA2326119@infradead.org> (raw)
In-Reply-To: <f3141eb3-9938-a216-a9f8-cb193589a657@kernel.dk>
On Wed, Feb 24, 2021 at 09:48:21AM -0700, Jens Axboe wrote:
> Would make sense to rename blk_get_request() to blk_mq_alloc_request()
> and then we have API symmetry. The get/put don't make sense when there
> are no references involved.
>
> But it's a lot of churn for very little reward, which is always kind
> of annoying. Especially for the person that has to carry the patches.
Let's do the following:
- move the initialize_rq_fn call from blk_get_request into
blk_mq_alloc_request and make the former a trivial alias for the
latter
- migrate to the blk_mq_* versions on a per-driver/subsystem basis.
The scsi migration depends on the first item above, so it will have
to go with that or wait for the next merge window
- don't migrate the legacy ide driver, as it is about to be removed and
has a huge number of blk_get_request calls
next prev parent reply other threads:[~2021-02-24 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 21:11 [RFC PATCH] blk-core: remove blk_put_request() Chaitanya Kulkarni
2021-02-24 11:53 ` Stefan Hajnoczi
2021-02-24 16:48 ` Jens Axboe
2021-02-24 18:55 ` Christoph Hellwig [this message]
2021-02-25 2:01 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224185521.GA2326119@infradead.org \
--to=hch@infradead.org \
--cc=Kai.Makisara@kolumbus.fi \
--cc=agk@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=baolin.wang@linaro.org \
--cc=beanhuo@micron.com \
--cc=bfields@fieldses.org \
--cc=bp@alien8.de \
--cc=cang@codeaurora.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dgilbert@interlog.com \
--cc=dm-devel@redhat.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=jaegeuk@kernel.org \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=richard.peng@oppo.com \
--cc=snitzer@redhat.com \
--cc=stanley.chu@mediatek.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=tim@cyberelk.net \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=zliua@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox