public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
	hare@suse.de, colin.king@canonical.com
Subject: [PATCH 4/4] sg: sg_common_write: remove debug remnant
Date: Thu, 11 Mar 2021 13:14:23 -0500	[thread overview]
Message-ID: <20210311181423.137646-5-dgilbert@interlog.com> (raw)
In-Reply-To: <20210311181423.137646-1-dgilbert@interlog.com>

The removed check was added as part of scattergun debugging to
find a problem that was fixed elsewhere. The associated SG_LOG
message has never been seen in testing.

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
---
 drivers/scsi/sg.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index b6e06e039d5b..9593f8eaf56c 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1120,11 +1120,6 @@ sg_common_write(struct sg_comm_wr_t *cwrp)
 		res = -EIDRM;	/* this failure unexpected but observed */
 		goto err_out;
 	}
-	if (xa_get_mark(&fp->srp_arr, srp->rq_idx, SG_XA_RQ_FREE)) {
-		SG_LOG(1, fp, "%s: ahhh, request erased!!!\n", __func__);
-		res = -ENODEV;
-		goto err_out;
-	}
 	srp->rq->timeout = cwrp->timeout;
 	sg_execute_cmd(fp, srp);
 	return srp;
-- 
2.25.1


      parent reply	other threads:[~2021-03-11 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 18:14 [PATCH 0/4] sg: fixes for 5.13/scsi-staging Douglas Gilbert
2021-03-11 18:14 ` [PATCH 1/4] sg: sg_rq_map_kern: fix uninitialized Douglas Gilbert
2021-03-11 18:14 ` [PATCH 2/4] sg: sg_remove_sfp_usercontext: remove NULL check Douglas Gilbert
2021-03-11 18:14 ` [PATCH 3/4] sg: sg_rq_end_io: set SG_FRQ_ISSUED Douglas Gilbert
2021-03-11 18:14 ` Douglas Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311181423.137646-5-dgilbert@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=colin.king@canonical.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox