Re: [PATCH 1/7] Revert "qla2xxx: Make sure that aborted commands are freed"

Daniel Wagner
2021-03-16T08:26:22Z

On Mon, Mar 15, 2021 at 08:56:49PM -0700, Bart Van Assche wrote:
> Calling vha->hw->tgt.tgt_ops->free_cmd() from qlt_xmit_response() is wrong
> since the command for which a response is sent must remain valid until the
> SCSI target core calls .release_cmd().

The commit message from 0dcec41acb85 ("scsi: qla2xxx: Make sure that
aborted commands are freed") says 'avoids that the code for removing a
session hangs due to commands that do not make progress'.

As this patch reverts the change, is the problem mentioned gone? Did
some other change fix it? Just wondering.