Re: [PATCH 7/7] qla2xxx: Always check the return value of qla24xx_get_isp_stats()

Bart Van Assche
2021-03-16T20:41:04Z

On 3/16/21 1:48 AM, Daniel Wagner wrote:
> On Mon, Mar 15, 2021 at 08:56:55PM -0700, Bart Van Assche wrote:
>> /* reset firmware statistics */
>> - qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0);
>> + rval = qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0);
>> + WARN_ONCE(rval != QLA_SUCCESS, "rval = %d\n", rval);
>
> ql_log() instead of WARN_ONCE? The function uses ql_log() if
> dma_alloc_coherrent() fails a few lines above.

Hi Daniel,

I will make that change.

Thanks,

Bart.