Re: [PATCH 1/7] Revert "qla2xxx: Make sure that aborted commands are freed"

Himanshu Madhani
2021-03-17T17:38:24Z

> On Mar 16, 2021, at 3:28 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 3/16/21 9:25 AM, Himanshu Madhani wrote:
>> Curious …. What triggered this revert? Can you share your motivation for this revert.
>
> Hi Himanshu,
>
> It has been observed that the following scenario triggers a kernel crash:
> - qlt_xmit_response() calls qlt_check_reserve_free_req().
> - qlt_check_reserve_free_req() returns -EAGAIN.
> - qlt_xmit_response() calls vha->hw->tgt.tgt_ops->free_cmd(cmd).
> - transport_handle_queue_full() tries to retransmit the response.
>
> I will add this information to the patch description.
>
> Bart.

Thanks, once you add more information to the patch, you can add my R-B

—
Himanshu Madhani Oracle Linux Engineering