Re: [PATCH 1/7] Revert "qla2xxx: Make sure that aborted commands are freed"

Bart Van Assche
2021-03-16T20:29:49Z

On 3/16/21 9:25 AM, Himanshu Madhani wrote:
> Curious …. What triggered this revert? Can you share your motivation for this revert.

Hi Himanshu,

It has been observed that the following scenario triggers a kernel crash:
- qlt_xmit_response() calls qlt_check_reserve_free_req().
- qlt_check_reserve_free_req() returns -EAGAIN.
- qlt_xmit_response() calls vha->hw->tgt.tgt_ops->free_cmd(cmd).
- transport_handle_queue_full() tries to retransmit the response.

I will add this information to the patch description.

Bart.