From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F0AC433E1 for ; Mon, 22 Mar 2021 14:23:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F336861998 for ; Mon, 22 Mar 2021 14:23:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbhCVOWi (ORCPT ); Mon, 22 Mar 2021 10:22:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32414 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230484AbhCVOWS (ORCPT ); Mon, 22 Mar 2021 10:22:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616422937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ejb4n98u9rBNHKiaP4ARz/PV6FJIULattwWWzRok730=; b=PblQLzqWIQ/9+gO4qXNG8EZiglxJx8tU/6qr2wCNGdcxlidamO3yBNy5a7FG5s4cfiGzTF ydIGLWaTJsQDnmGCvASa+DTyKEVW7OnYQIo644Bi51SzZRJHyrV0Cki/zFTdvltFn0Htaw av1ZjzkuHQgCshpJNAKOIR2pV41RF2k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383--br8DkJtPWi7qsa4i_c22Q-1; Mon, 22 Mar 2021 10:22:13 -0400 X-MC-Unique: -br8DkJtPWi7qsa4i_c22Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F3E8780364C; Mon, 22 Mar 2021 14:22:11 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67B613697; Mon, 22 Mar 2021 14:22:08 +0000 (UTC) Date: Mon, 22 Mar 2021 10:22:07 -0400 From: Mike Snitzer To: Christoph Hellwig , Zhiqiang Liu Cc: agk@redhat.com, dm-devel@redhat.com, "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linfeilong , lixiaokeng , "wubo (T)" Subject: Re: md/dm-mpath: check whether all pgpaths have same uuid in multipath_ctr() Message-ID: <20210322142207.GB30698@redhat.com> References: <20210322081155.GE1946905@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322081155.GE1946905@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Mon, Mar 22 2021 at 4:11am -0400, Christoph Hellwig wrote: > On Sat, Mar 20, 2021 at 03:19:23PM +0800, Zhiqiang Liu wrote: > > From: Zhiqiang Liu > > > > When we make IO stress test on multipath device, there will > > be a metadata err because of wrong path. In the test, we > > concurrent execute 'iscsi device login|logout' and > > 'multipath -r' command with IO stress on multipath device. > > In some case, systemd-udevd may have not time to process > > uevents of iscsi device logout|login, and then 'multipath -r' > > command triggers multipathd daemon calls ioctl to load table > > with incorrect old device info from systemd-udevd. > > Then, one iscsi path may be incorrectly attached to another > > multipath which has different uuid. Finally, the metadata err > > occurs when umounting filesystem to down write metadata on > > the iscsi device which is actually not owned by the multipath > > device. > > > > So we need to check whether all pgpaths of one multipath have > > the same uuid, if not, we should throw a error. > > > > Signed-off-by: Zhiqiang Liu > > Signed-off-by: lixiaokeng > > Signed-off-by: linfeilong > > Signed-off-by: Wubo > > --- > > drivers/md/dm-mpath.c | 52 +++++++++++++++++++++++++++++++++++++++++ > > drivers/scsi/scsi_lib.c | 1 + > > 2 files changed, 53 insertions(+) > > > > diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c > > index bced42f082b0..f0b995784b53 100644 > > --- a/drivers/md/dm-mpath.c > > +++ b/drivers/md/dm-mpath.c > > @@ -24,6 +24,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -1169,6 +1170,45 @@ static int parse_features(struct dm_arg_set *as, struct multipath *m) > > return r; > > } > > > > +#define SCSI_VPD_LUN_ID_PREFIX_LEN 4 > > +#define MPATH_UUID_PREFIX_LEN 7 > > +static int check_pg_uuid(struct priority_group *pg, char *md_uuid) > > +{ > > + char pgpath_uuid[DM_UUID_LEN] = {0}; > > + struct request_queue *q; > > + struct pgpath *pgpath; > > + struct scsi_device *sdev; > > + ssize_t count; > > + int r = 0; > > + > > + list_for_each_entry(pgpath, &pg->pgpaths, list) { > > + q = bdev_get_queue(pgpath->path.dev->bdev); > > + sdev = scsi_device_from_queue(q); > > Common dm-multipath code should never poke into scsi internals. This > is something for the device handler to check. It probably also won't > work for all older devices. Definitely. But that aside, userspace (multipathd) _should_ be able to do extra validation, _before_ pushing down a new table to the kernel, rather than forcing the kernel to do it.