public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Viswas G <Viswas.G@microchip.com>,
	linux-scsi@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	Vasanthalakshmi.Tharmarajan@microchip.com,
	Viswas.G@microchip.com, Ruksar.devadi@microchip.com,
	vishakhavc@google.com, radha@google.com,
	jinpu.wang@cloud.ionos.com,
	Ashokkumar N <Ashokkumar.N@microchip.com>,
	John Garry <john.garry@huawei.com>
Subject: [kbuild] Re: [PATCH v2 1/7] pm80xx: Add sysfs attribute to check mpi state
Date: Thu, 25 Mar 2021 10:10:44 +0300	[thread overview]
Message-ID: <20210325071044.GV1667@kadam> (raw)
In-Reply-To: <20210324170357.9765-2-Viswas.G@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 2169 bytes --]

Hi Viswas,

url:    https://github.com/0day-ci/linux/commits/Viswas-G/pm80xx-updates/20210325-005709
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git  for-next
config: x86_64-randconfig-m001-20210323 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/scsi/pm8001/pm8001_ctl.c:916 ctl_mpi_state_show() warn: mask and shift to zero

Old smatch warnings:
drivers/scsi/pm8001/pm8001_ctl.c:758 pm8001_update_flash() warn: inconsistent indenting

vim +916 drivers/scsi/pm8001/pm8001_ctl.c

47c563cdbc763e Vishakha Channapattan 2021-03-24  905  static ssize_t ctl_mpi_state_show(struct device *cdev,
47c563cdbc763e Vishakha Channapattan 2021-03-24  906  		struct device_attribute *attr, char *buf)
47c563cdbc763e Vishakha Channapattan 2021-03-24  907  {
47c563cdbc763e Vishakha Channapattan 2021-03-24  908  	struct Scsi_Host *shost = class_to_shost(cdev);
47c563cdbc763e Vishakha Channapattan 2021-03-24  909  	struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost);
47c563cdbc763e Vishakha Channapattan 2021-03-24  910  	struct pm8001_hba_info *pm8001_ha = sha->lldd_ha;
47c563cdbc763e Vishakha Channapattan 2021-03-24  911  	unsigned int mpidw0;
47c563cdbc763e Vishakha Channapattan 2021-03-24  912  	int c;
47c563cdbc763e Vishakha Channapattan 2021-03-24  913  
47c563cdbc763e Vishakha Channapattan 2021-03-24  914  	mpidw0 = pm8001_mr32(pm8001_ha->general_stat_tbl_addr, 0);
47c563cdbc763e Vishakha Channapattan 2021-03-24  915  	c = sysfs_emit(buf, "MPI-S=%s\t HMI_ERR=%x\n", mpiStateText[mpidw0 & 0x0003],
47c563cdbc763e Vishakha Channapattan 2021-03-24 @916  			((mpidw0 & 0xff00) >> 16));
                                                                         ^^^^^^^^^^^^^^^^^^^^^^^
0xff00 >> 16 is zero.

47c563cdbc763e Vishakha Channapattan 2021-03-24  917  	return c;
47c563cdbc763e Vishakha Channapattan 2021-03-24  918  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org 

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31712 bytes --]

[-- Attachment #3: Type: text/plain, Size: 149 bytes --]

_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org

  parent reply	other threads:[~2021-03-25  7:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 17:03 [PATCH v2 0/7] pm80xx updates Viswas G
2021-03-24 17:03 ` [PATCH v2 1/7] pm80xx: Add sysfs attribute to check mpi state Viswas G
2021-03-24 20:04   ` kernel test robot
2021-03-24 20:04   ` [RFC PATCH] pm80xx: mpiStateText[] can be static kernel test robot
2021-03-25  4:55   ` [PATCH v2 1/7] pm80xx: Add sysfs attribute to check mpi state Jinpu Wang
2021-03-25  7:10   ` Dan Carpenter [this message]
2021-03-24 17:03 ` [PATCH v2 2/7] pm80xx: Add sysfs attribute to track RAAE count Viswas G
2021-03-25  4:49   ` Jinpu Wang
2021-03-24 17:03 ` [PATCH v2 3/7] pm80xx: Add sysfs attribute to track iop0 count Viswas G
2021-03-25  4:48   ` Jinpu Wang
2021-03-24 17:03 ` [PATCH v2 4/7] pm80xx: Add sysfs attribute to track iop1 count Viswas G
2021-03-25  4:49   ` Jinpu Wang
2021-03-24 17:03 ` [PATCH v2 5/7] pm80xx: Completing pending IO after fatal error Viswas G
2021-03-24 17:03 ` [PATCH v2 6/7] pm80xx: Reset PI and CI memory during re-initialize Viswas G
2021-03-24 17:03 ` [PATCH v2 7/7] pm80xx: remove global lock from outbound queue processing Viswas G

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210325071044.GV1667@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Ashokkumar.N@microchip.com \
    --cc=Ruksar.devadi@microchip.com \
    --cc=Vasanthalakshmi.Tharmarajan@microchip.com \
    --cc=Viswas.G@microchip.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=john.garry@huawei.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=radha@google.com \
    --cc=vishakhavc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox