Re: [PATCH v2 4/7] pm80xx: Add sysfs attribute to track iop1 count

Jinpu Wang
2021-03-25T04:50:32Z

On Wed, Mar 24, 2021 at 5:54 PM Viswas G <Viswas.G@microchip.com> wrote:
>
> From: Vishakha Channapattan <vishakhavc@google.com>
>
> A new sysfs variable 'ctl_iop1_count' is being introduced that tells if
> the controller is alive by indicating controller ticks. If on subsequent
> run we see the ticks changing that indicates that controller is not
> dead.
>
> Tested: Using 'ctl_iop1_count' sysfs variable we can see ticks
> incrementing
> mvae14:~# cat /sys/class/scsi_host/host*/ctl_iop1_count
> 0x00000069
> 0x0000006b
> 0x0000006d
> 0x00000072
>
> Signed-off-by: Vishakha Channapattan <vishakhavc@google.com>
> Signed-off-by: Viswas G <Viswas.G@microchip.com>
> Signed-off-by: Ruksar Devadi <Ruksar.devadi@microchip.com>
> Signed-off-by: Ashokkumar N <Ashokkumar.N@microchip.com>
> Signed-off-by: Radha Ramachandran <radha@google.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
> index b8170da49112..78d5f573eac8 100644
> --- a/drivers/scsi/pm8001/pm8001_ctl.c
> +++ b/drivers/scsi/pm8001/pm8001_ctl.c
> @@ -964,6 +964,29 @@ static ssize_t ctl_iop0_count_show(struct device *cdev,
> }
> static DEVICE_ATTR_RO(ctl_iop0_count);
>
> +/**
> + * ctl_iop1_count_show - controller iop1 count check
> + * @cdev: pointer to embedded class device
> + * @buf: the buffer returned
> + *
> + * A sysfs 'read-only' shost attribute.
> + */
> +
> +static ssize_t ctl_iop1_count_show(struct device *cdev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct Scsi_Host *shost = class_to_shost(cdev);
> + struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost);
> + struct pm8001_hba_info *pm8001_ha = sha->lldd_ha;
> + unsigned int iop1cnt;
> + int c;
> +
> + iop1cnt = pm8001_mr32(pm8001_ha->general_stat_tbl_addr, 20);
> + c = sysfs_emit(buf, "0x%08x\n", iop1cnt);
> + return c;
> +}
> +static DEVICE_ATTR_RO(ctl_iop1_count);
> +
> struct device_attribute *pm8001_host_attrs[] = {
> &dev_attr_interface_rev,
> &dev_attr_controller_fatal_error,
> @@ -990,6 +1013,7 @@ struct device_attribute *pm8001_host_attrs[] = {
> &dev_attr_ctl_mpi_state,
> &dev_attr_ctl_raae_count,
> &dev_attr_ctl_iop0_count,
> + &dev_attr_ctl_iop1_count,
> NULL,
> };
>
> --
> 2.16.3
>