From: Christoph Hellwig <hch@infradead.org>
To: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
linux-scsi@vger.kernel.org,
Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
Subject: Re: [PATCH v2 01/24] mpi3mr: add mpi30 Rev-R headers and Kconfig
Date: Tue, 20 Apr 2021 07:33:25 +0100 [thread overview]
Message-ID: <20210420063325.GA3528859@infradead.org> (raw)
In-Reply-To: <15a1b800b7b3f2ab52e189700b07f412@mail.gmail.com>
On Mon, Apr 19, 2021 at 03:50:50PM +0530, Kashyap Desai wrote:
> Hi Bart - This is possible to modify, but I have to forward this feedback to
> group who owns the MPI header within a Broadcom.
> It will be difficult to accommodate requested to change in this series.
>
> I have marked your feedback as TBD for upcoming driver update (not in
> current patch set). In V3, this is not accommodated. Hope this is OK with
> you.
Please stop this crap. There is absolute no reason at all ofr this
mess.
Please just write a normal driver with a hand-generated header. That
requires less work than all the arguing here and means people can
immediately jump in and actually understand the driver, unlike the
current train wreck. And looking at mpt2sas/mpt3sas is is pretty clear
that the comon header scheme does not work at all.
next prev parent reply other threads:[~2021-04-20 6:34 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 2:04 [PATCH v2 00/24] Introducing mpi3mr driver Kashyap Desai
2021-04-07 2:04 ` [PATCH v2 01/24] mpi3mr: add mpi30 Rev-R headers and Kconfig Kashyap Desai
2021-04-15 10:30 ` Tomas Henzl
2021-04-15 20:31 ` Bart Van Assche
2021-04-16 10:53 ` Kashyap Desai
2021-04-16 15:40 ` Bart Van Assche
2021-04-19 10:20 ` Kashyap Desai
2021-04-20 6:33 ` Christoph Hellwig [this message]
2021-04-23 13:18 ` Kashyap Desai
2021-04-07 2:04 ` [PATCH v2 02/24] mpi3mr: base driver code Kashyap Desai
2021-04-07 4:17 ` kernel test robot
2021-04-07 4:33 ` kernel test robot
2021-04-07 2:04 ` [PATCH v2 03/24] mpi3mr: create operational request and reply queue pair Kashyap Desai
2021-04-15 10:35 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 04/24] mpi3mr: add support of queue command processing Kashyap Desai
2021-04-15 10:36 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 05/24] mpi3mr: add support of internal watchdog thread Kashyap Desai
2021-04-15 10:37 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 06/24] mpi3mr: add support of event handling part-1 Kashyap Desai
2021-04-15 10:40 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 07/24] mpi3mr: add support of event handling pcie devices part-2 Kashyap Desai
2021-04-15 11:10 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 08/24] mpi3mr: add support of event handling part-3 Kashyap Desai
2021-04-15 11:11 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 09/24] mpi3mr: add support for recovering controller Kashyap Desai
2021-04-15 11:21 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 10/24] mpi3mr: add support of timestamp sync with firmware Kashyap Desai
2021-04-15 11:22 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 11/24] mpi3mr: print ioc info for debugging Kashyap Desai
2021-04-15 11:55 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 12/24] mpi3mr: add bios_param shost template hook Kashyap Desai
2021-04-15 11:56 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 13/24] mpi3mr: implement scsi error handler hooks Kashyap Desai
2021-04-07 2:04 ` [PATCH v2 14/24] mpi3mr: add change queue depth support Kashyap Desai
2021-04-15 12:16 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 15/24] mpi3mr: allow certain commands during pci-remove hook Kashyap Desai
2021-04-15 12:19 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 16/24] mpi3mr: hardware workaround for UNMAP commands to nvme drives Kashyap Desai
2021-04-15 12:20 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 17/24] mpi3mr: add support of threaded isr Kashyap Desai
2021-04-15 12:22 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 18/24] mpi3mr: add complete support of soft reset Kashyap Desai
2021-04-15 12:32 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 19/24] mpi3mr: print pending host ios for debug Kashyap Desai
2021-04-15 12:43 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 20/24] mpi3mr: wait for pending IO completions upon detection of VD IO timeout Kashyap Desai
2021-04-15 12:45 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 21/24] mpi3mr: add support of PM suspend and resume Kashyap Desai
2021-04-15 12:46 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 22/24] mpi3mr: add support of DSN secure fw check Kashyap Desai
2021-04-15 12:48 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 23/24] mpi3mr: add eedp dif dix support Kashyap Desai
2021-04-15 12:50 ` Tomas Henzl
2021-04-07 2:04 ` [PATCH v2 24/24] mpi3mr: add event handling debug prints Kashyap Desai
2021-04-15 12:52 ` Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420063325.GA3528859@infradead.org \
--to=hch@infradead.org \
--cc=bvanassche@acm.org \
--cc=kashyap.desai@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox