From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D60F9C433B4 for ; Tue, 20 Apr 2021 12:37:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AB0660241 for ; Tue, 20 Apr 2021 12:37:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231526AbhDTMh5 (ORCPT ); Tue, 20 Apr 2021 08:37:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:50690 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbhDTMh4 (ORCPT ); Tue, 20 Apr 2021 08:37:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2DE02B229; Tue, 20 Apr 2021 12:37:24 +0000 (UTC) Date: Tue, 20 Apr 2021 14:37:23 +0200 From: Daniel Wagner To: Randy Dunlap Cc: linux-scsi@vger.kernel.org, GR-QLogic-Storage-Upstream@marvell.com, linux-nvme@lists.infradead.org, Hannes Reinecke , Nilesh Javali , Arun Easi Subject: Re: [RFC] qla2xxx: Add dev_loss_tmo kernel module options Message-ID: <20210420123723.bregf4debvyincpo@beryllium.lan> References: <20210419100014.47144-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Randy, On Mon, Apr 19, 2021 at 09:19:13AM -0700, Randy Dunlap wrote: > > +int ql2xdev_loss_tmo = 60; > > +module_param(ql2xdev_loss_tmo, int, 0444); > > +MODULE_PARM_DESC(ql2xdev_loss_tmo, > > + "Time to wait for device to recover before reporting\n" > > + "an error. Default is 60 seconds\n"); > > No need for the \n in the quoted string. Just change it to a space. I just followed the current style in this file. I guess this style question is up to the maintainers to decide what they want. Thanks, Daniel