Re: [RFC PATCH 00/42] SCSI result cleanup, part 2

Bart Van Assche
2021-04-22T16:29:01Z

On 4/22/21 1:49 AM, Hannes Reinecke wrote:
> So the midlayer can be reduced to handling just the host byte and the
> status byte. Whether this is by means of a union or something else
> doesn't really matter; this patchset doesn't prevent any of this from
> happening.

Something that is important to mention is that struct scsi_request is
not only used by the SCSI code but also by the IDE code. Changing the
'result' member of struct scsi_request also affects the IDE code.

These are the SCSI and block layer calls in the IDE code that I am aware
of and that assume that a struct scsi_request immediately follows struct
request:
* scsi_req_init().
* scsi_cmd_blk_ioctl().

I have not yet tried to evaluate how much work it would take to split
the code in block/scsi_ioctl.c such that it supports different layouts
for the data that follows struct request for IDE and SCSI.

Thanks,

Bart.