From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CF2C433ED for ; Mon, 26 Apr 2021 14:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C191F61040 for ; Mon, 26 Apr 2021 14:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233923AbhDZOwj (ORCPT ); Mon, 26 Apr 2021 10:52:39 -0400 Received: from verein.lst.de ([213.95.11.211]:41621 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232575AbhDZOwj (ORCPT ); Mon, 26 Apr 2021 10:52:39 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 256D668C4E; Mon, 26 Apr 2021 16:51:55 +0200 (CEST) Date: Mon, 26 Apr 2021 16:51:55 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: "Martin K. Petersen" , Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org, Bart van Assche Subject: Re: [PATCH 02/39] scsi_ioctl: return error code when blk_rq_map_kern() fails Message-ID: <20210426145155.GC22120@lst.de> References: <20210423113944.42672-1-hare@suse.de> <20210423113944.42672-3-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423113944.42672-3-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Fri, Apr 23, 2021 at 01:39:07PM +0200, Hannes Reinecke wrote: > The callers of sg_scsi_ioctl() already check for negative > return values, so we can drop the usage of DRIVER_ERROR > and return the error from blk_rq_map_kern() instead. > > Signed-off-by: Hannes Reinecke Looks good, Reviewed-by: Christoph Hellwig