Re: [PATCH 16/18] aacraid: store target id in host_scribble

Hannes Reinecke
2021-05-04T06:18:43Z

On 5/4/21 5:22 AM, Bart Van Assche wrote:
> On 5/3/21 8:03 AM, Hannes Reinecke wrote:
>> The probe_container mechanism requires a target id to be present,
>> even if the device itself isn't present (yet).
>> As we're now allocating internal commands the target id of the
>> device is immutable, so store the requested target id in the
>> host_scribble field.
>
> A more elegant solution is probably to introduce private data per SCSI
> command and to set the .cmd_size member in the SCSI host template. I'd
> like to get rid of the host_scribble field because it makes the SCSI
> command data structure larger than necessary for SCSI LLDs that don't
> use 'host_scribble'.
>
Ah. Good idea, both with using the .cmd_size and removing the
host_scribble field.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer