Re: [PATCH 07/18] scsi: revamp host device handling

Hannes Reinecke
2021-05-04T06:15:05Z

On 5/4/21 5:06 AM, Bart Van Assche wrote:
> On 5/3/21 8:03 AM, Hannes Reinecke wrote:
>> + * Attach a single scsi_device to the Scsi_Host. The primary aim
>> + * for this device is to serve as a container from which valid
>> + * scsi commands can be allocated from. Each scsi command will carry
>> + * an unused/free command tag,
>
> Shouldn't introducing this comment be deferred to the patch that
> actually reserves a tag for internal commands (this does not mean that
> I'm convinced that this is the right approach)?
>
Will do.

>> + * which then can be used by the LLDD to
>> + * send internal or passthrough commands without having to find a
>> + * valid command tag internally.
>
> Please change "valid SCSI commands" into "internal SCSI commands".
>
Okay.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer