Re: [PATCH 04/18] fnic: use internal commands

Hannes Reinecke
2021-05-04T06:13:02Z

On 5/4/21 4:25 AM, Bart Van Assche wrote:
> On 5/3/21 8:03 AM, Hannes Reinecke wrote:
>> - tag = sc->request->tag;
>> - if (unlikely(tag < 0)) {
>> - /*
>> - * Really should fix the midlayer to pass in a proper
>> - * request for ioctls...
>> - */
>> - tag = fnic_scsi_host_start_tag(fnic, sc);
>> - if (unlikely(tag == SCSI_NO_TAG))
>> - goto fnic_device_reset_end;
>> - tag_gen_flag = 1;
>> - new_sc = 1;
>> - }
>
> Since this patch removes the only callers of fnic_scsi_host_start_tag()
> and fnic_scsi_host_end_tag(), please modify this patch such that it also
> removes these functions.
>
Of course.

Will do in the next round.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer