Re: [PATCH 02/18] fnic: use scsi_host_busy_iter() to traverse commands

Christoph Hellwig
2021-05-04T09:50:55Z

On Mon, May 03, 2021 at 05:03:17PM +0200, Hannes Reinecke wrote:
> Use scsi_host_busy_iter() to traverse commands instead of
> hand-crafted routines walking the command list.

While the replacement looks like the right thing to do at the micro level,
can we take one step back?

Shouldn't completing commands be left entirely to the SCSI EH code
instead of messing with it in the driver?