Re: [PATCH 06/18] scsi: Use dummy inquiry data for the host device

Hannes Reinecke
2021-05-04T06:14:04Z

On 5/4/21 4:52 AM, Bart Van Assche wrote:
> On 5/3/21 8:03 AM, Hannes Reinecke wrote:
>> +/**
>> + * scsi_device_is_host_dev - Check if a scsi device is a host device
>> + * @sdev: SCSI device to test
>> + *
>> + * Returns: true if @sdev is a host device, false otherwise
>> + */
>> +bool scsi_device_is_host_dev(struct scsi_device *sdev)
>> +{
>> + return ((const unsigned char *)sdev->inquiry == scsi_null_inquiry);
>> +}
>
> No parentheses around the expression in a return statement please.
>
Okay.

>> +EXPORT_SYMBOL_GPL(scsi_device_is_host_dev);
>
> Does this mean that this function will be used outside the SCSI core?
>
Will have to check; might be a left-over from previous iterations.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer