Re: [PATCH 03/18] scsi: add scsi_{get,put}_internal_cmd() helper

John Garry
2021-06-24T10:01:41Z

On 23/06/2021 14:48, Hannes Reinecke wrote:
>>
>> I will note that we also bypass the queue budgeting in
>> blk_mq_ops.{get,put}_budget. I figure that is not an issue...
>>
>> BTW, any chance of a new version?
>>
> I have _so_ no idea.
>
> The review from Christoph to patch 07/18 he (apparently) changed his
> mind for the current implementation of using scsi_get_host_dev(), citing
> an approach I had been implemented for v2 (and which got changed due to
> his reviews for v2).
> So no I'm not sure if he retracted on his earlier review, or if he just
> had forgotten about it.
> And before I get clarification from him I can't really move forward, as
> both reviews contradict each other.
>
> Christoph?

I see.

FWIW, not using scsi_get_host_dev() means that internal command
scsi_cmnd.device cannot be set. But then many fields are not set there.

I suppose that if we delete scsi_get_host_dev() now [as it has no user],
then that will narrow the choice...

BTW, I was just checking the v7, and we have no queue sysfs folder for
that host scsi_device. Regardless of how the queue is created - v2 vs v7
method - I think that we should have that somehow.

Thanks,
John