Re: [PATCH 10/50] zfcp: Use blk_req() instead of scsi_cmnd.request

Benjamin Block
2021-05-17T17:29:44Z

On Fri, May 14, 2021 at 02:33:16PM -0700, Bart Van Assche wrote:
> Prepare for removal of the request pointer by using blk_req() instead. This
> patch does not change any functionality.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/s390/scsi/zfcp_fsf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c
> index 2e4804ef2fb9..ac9223a7677d 100644
> --- a/drivers/s390/scsi/zfcp_fsf.c
> +++ b/drivers/s390/scsi/zfcp_fsf.c
> @@ -2377,7 +2377,7 @@ static void zfcp_fsf_req_trace(struct zfcp_fsf_req *req, struct scsi_cmnd *scsi)
> }
> }
>
> - blk_add_driver_data(scsi->request, &blktrc, sizeof(blktrc));
> + blk_add_driver_data(blk_req(scsi), &blktrc, sizeof(blktrc));
> }
>
> /**

Looks good.

Acked-by: Benjamin Block <bblock@linux.ibm.com>

If you only rename `blk_req()`, like you suggested in the conversation
with Christoph, and nothing else changes, feel free to carry the
Acked-by over.

--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294