From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CFBC433B4 for ; Sat, 15 May 2021 06:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF64D61406 for ; Sat, 15 May 2021 06:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbhEOGso (ORCPT ); Sat, 15 May 2021 02:48:44 -0400 Received: from verein.lst.de ([213.95.11.211]:52579 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231481AbhEOGsn (ORCPT ); Sat, 15 May 2021 02:48:43 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 363C268AFE; Sat, 15 May 2021 08:47:28 +0200 (CEST) Date: Sat, 15 May 2021 08:47:27 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Ming Lei , "James E.J. Bottomley" Subject: Re: [PATCH 01/50] core: Introduce the blk_req() function Message-ID: <20210515064727.GA26723@lst.de> References: <20210514213356.5264-1-bvanassche@acm.org> <20210514213356.5264-2-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210514213356.5264-2-bvanassche@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org > +/* Variant of blk_mq_rq_from_pdu() that verifies the type of its argument. */ > +static inline struct request *blk_req(struct scsi_cmnd *scmd) Please don't use a blk_ prefix for a SCSI funtion. Why not scsi_scmd_to_rq or something like that?