From: Kashyap Desai <kashyap.desai@broadcom.com>
To: linux-scsi@vger.kernel.org
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
steve.hagan@broadcom.com, peter.rivera@broadcom.com,
mpi3mr-linuxdrv.pdl@broadcom.com,
Kashyap Desai <kashyap.desai@broadcom.com>,
sathya.prakash@broadcom.com
Subject: [PATCH v6 11/24] mpi3mr: print ioc info for debugging
Date: Thu, 20 May 2021 20:55:32 +0530 [thread overview]
Message-ID: <20210520152545.2710479-12-kashyap.desai@broadcom.com> (raw)
In-Reply-To: <20210520152545.2710479-1-kashyap.desai@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 4176 bytes --]
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: sathya.prakash@broadcom.com
---
drivers/scsi/mpi3mr/mpi3mr_fw.c | 95 +++++++++++++++++++++++++++++++++
drivers/scsi/mpi3mr/mpi3mr_os.c | 1 +
2 files changed, 96 insertions(+)
diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
index ef15a37..797f273 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
@@ -2534,6 +2534,99 @@ out:
return retval;
}
+/* Protocol type to name mapper structure*/
+static const struct {
+ u8 protocol;
+ char *name;
+} mpi3mr_protocols[] = {
+ { MPI3_IOCFACTS_PROTOCOL_SCSI_INITIATOR, "Initiator" },
+ { MPI3_IOCFACTS_PROTOCOL_SCSI_TARGET, "Target" },
+ { MPI3_IOCFACTS_PROTOCOL_NVME, "NVMe attachment" },
+};
+
+/* Capability to name mapper structure*/
+static const struct {
+ u32 capability;
+ char *name;
+} mpi3mr_capabilities[] = {
+ { MPI3_IOCFACTS_CAPABILITY_RAID_CAPABLE, "RAID" },
+};
+
+/**
+ * mpi3mr_print_ioc_info - Display controller information
+ * @mrioc: Adapter instance reference
+ *
+ * Display controller personalit, capability, supported
+ * protocols etc.
+ *
+ * Return: Nothing
+ */
+static void
+mpi3mr_print_ioc_info(struct mpi3mr_ioc *mrioc)
+{
+ int i = 0, bytes_wrote = 0;
+ char personality[16];
+ char protocol[50] = {0};
+ char capabilities[100] = {0};
+ bool is_string_nonempty = false;
+ struct mpi3mr_compimg_ver *fwver = &mrioc->facts.fw_ver;
+
+ switch (mrioc->facts.personality) {
+ case MPI3_IOCFACTS_FLAGS_PERSONALITY_EHBA:
+ strncpy(personality, "Enhanced HBA", sizeof(personality));
+ break;
+ case MPI3_IOCFACTS_FLAGS_PERSONALITY_RAID_DDR:
+ strncpy(personality, "RAID", sizeof(personality));
+ break;
+ default:
+ strncpy(personality, "Unknown", sizeof(personality));
+ break;
+ }
+
+ ioc_info(mrioc, "Running in %s Personality", personality);
+
+ ioc_info(mrioc, "FW version(%d.%d.%d.%d.%d.%d)\n",
+ fwver->gen_major, fwver->gen_minor, fwver->ph_major,
+ fwver->ph_minor, fwver->cust_id, fwver->build_num);
+
+ for (i = 0; i < ARRAY_SIZE(mpi3mr_protocols); i++) {
+ if (mrioc->facts.protocol_flags &
+ mpi3mr_protocols[i].protocol) {
+ if (is_string_nonempty &&
+ (bytes_wrote < sizeof(protocol)))
+ bytes_wrote += snprintf(protocol + bytes_wrote,
+ (sizeof(protocol) - bytes_wrote), ",");
+
+ if (bytes_wrote < sizeof(protocol))
+ bytes_wrote += snprintf(protocol + bytes_wrote,
+ (sizeof(protocol) - bytes_wrote), "%s",
+ mpi3mr_protocols[i].name);
+ is_string_nonempty = true;
+ }
+ }
+
+ bytes_wrote = 0;
+ is_string_nonempty = false;
+ for (i = 0; i < ARRAY_SIZE(mpi3mr_capabilities); i++) {
+ if (mrioc->facts.protocol_flags &
+ mpi3mr_capabilities[i].capability) {
+ if (is_string_nonempty &&
+ (bytes_wrote < sizeof(capabilities)))
+ bytes_wrote += snprintf(capabilities + bytes_wrote,
+ (sizeof(capabilities) - bytes_wrote), ",");
+
+ if (bytes_wrote < sizeof(capabilities))
+ bytes_wrote += snprintf(capabilities + bytes_wrote,
+ (sizeof(capabilities) - bytes_wrote), "%s",
+ mpi3mr_capabilities[i].name);
+ is_string_nonempty = true;
+ }
+ }
+
+ ioc_info(mrioc, "Protocol=(%s), Capabilities=(%s)\n",
+ protocol, capabilities);
+}
+
/**
* mpi3mr_cleanup_resources - Free PCI resources
* @mrioc: Adapter instance reference
@@ -2792,6 +2885,8 @@ int mpi3mr_init_ioc(struct mpi3mr_ioc *mrioc, u8 re_init)
}
}
+ mpi3mr_print_ioc_info(mrioc);
+
retval = mpi3mr_alloc_reply_sense_bufs(mrioc);
if (retval) {
ioc_err(mrioc,
diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
index 9a54cc1..21e2ac4 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_os.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
@@ -337,6 +337,7 @@ void mpi3mr_invalidate_devhandles(struct mpi3mr_ioc *mrioc)
* mpi3mr_flush_scmd - Flush individual SCSI command
* @rq: Block request
* @data: Adapter instance reference
+ * @reserved: N/A. Currently not used
*
* Return the SCSI command to the upper layers if it is in LLD
* scope.
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2021-05-20 15:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 15:25 [PATCH v6 00/24] Introducing mpi3mr driver Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 01/24] mpi3mr: add mpi30 Rev-R headers and Kconfig Kashyap Desai
2021-05-26 19:08 ` Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 02/24] mpi3mr: base driver code Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 03/24] mpi3mr: create operational request and reply queue pair Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 04/24] mpi3mr: add support of queue command processing Kashyap Desai
2021-06-01 13:30 ` Hannes Reinecke
2021-05-20 15:25 ` [PATCH v6 05/24] mpi3mr: add support of internal watchdog thread Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 06/24] mpi3mr: add support of event handling part-1 Kashyap Desai
2021-06-01 13:32 ` Hannes Reinecke
2021-05-20 15:25 ` [PATCH v6 07/24] mpi3mr: add support of event handling pcie devices part-2 Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 08/24] mpi3mr: add support of event handling part-3 Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 09/24] mpi3mr: add support for recovering controller Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 10/24] mpi3mr: add support of timestamp sync with firmware Kashyap Desai
2021-05-20 15:25 ` Kashyap Desai [this message]
2021-06-01 13:33 ` [PATCH v6 11/24] mpi3mr: print ioc info for debugging Hannes Reinecke
2021-05-20 15:25 ` [PATCH v6 12/24] mpi3mr: add bios_param shost template hook Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 13/24] mpi3mr: implement scsi error handler hooks Kashyap Desai
2021-05-25 14:43 ` Tomas Henzl
2021-05-20 15:25 ` [PATCH v6 14/24] mpi3mr: add change queue depth support Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 15/24] mpi3mr: allow certain commands during pci-remove hook Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 16/24] mpi3mr: hardware workaround for UNMAP commands to nvme drives Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 17/24] mpi3mr: add support of threaded isr Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 18/24] mpi3mr: add complete support of soft reset Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 19/24] mpi3mr: print pending host ios for debug Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 20/24] mpi3mr: wait for pending IO completions upon detection of VD IO timeout Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 21/24] mpi3mr: add support of PM suspend and resume Kashyap Desai
2021-12-16 23:30 ` Bjorn Helgaas
2021-12-16 23:32 ` Bjorn Helgaas
2021-12-16 23:45 ` Bjorn Helgaas
2021-05-20 15:25 ` [PATCH v6 22/24] mpi3mr: add support of DSN secure fw check Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 23/24] mpi3mr: add eedp dif dix support Kashyap Desai
2021-05-20 15:25 ` [PATCH v6 24/24] mpi3mr: add event handling debug prints Kashyap Desai
2021-06-02 5:11 ` [PATCH v6 00/24] Introducing mpi3mr driver Martin K. Petersen
2021-06-02 5:27 ` Kashyap Desai
2021-06-08 3:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520152545.2710479-12-kashyap.desai@broadcom.com \
--to=kashyap.desai@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=peter.rivera@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=steve.hagan@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox