Re: [PATCH v2 4/5] megaraid_sas: Handle missing interrupts while re-enabling IRQs

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2757 bytes --]

Hi Chandrakanth,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next v5.13-rc2 next-20210521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chandrakanth-Patil/megaraid_sas-Update-driver-version-to-07-717-02-00-rc1/20210522-203404
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: i386-randconfig-a001-20210522 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/14f4c308962448ba3ff062098bed88de6acda8ab
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chandrakanth-Patil/megaraid_sas-Update-driver-version-to-07-717-02-00-rc1/20210522-203404
        git checkout 14f4c308962448ba3ff062098bed88de6acda8ab
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/megaraid/megaraid_sas_fusion.c: In function 'megasas_complete_cmd_dpc_fusion':
>> drivers/scsi/megaraid/megaraid_sas_fusion.c:3797:30: warning: variable 'irq_ctx' set but not used [-Wunused-but-set-variable]
    3797 |  struct megasas_irq_context *irq_ctx = NULL;
         |                              ^~~~~~~


vim +/irq_ctx +3797 drivers/scsi/megaraid/megaraid_sas_fusion.c

  3785	
  3786	/**
  3787	 * megasas_complete_cmd_dpc_fusion -	Completes command
  3788	 * @instance_addr:			Adapter soft state address
  3789	 *
  3790	 * Tasklet to complete cmds
  3791	 */
  3792	static void
  3793	megasas_complete_cmd_dpc_fusion(unsigned long instance_addr)
  3794	{
  3795		struct megasas_instance *instance =
  3796			(struct megasas_instance *)instance_addr;
> 3797		struct megasas_irq_context *irq_ctx = NULL;
  3798		u32 count, MSIxIndex;
  3799	
  3800		count = instance->msix_vectors > 0 ? instance->msix_vectors : 1;
  3801	
  3802		/* If we have already declared adapter dead, donot complete cmds */
  3803		if (atomic_read(&instance->adprecovery) == MEGASAS_HW_CRITICAL_ERROR)
  3804			return;
  3805	
  3806		for (MSIxIndex = 0 ; MSIxIndex < count; MSIxIndex++) {
  3807			irq_ctx = &instance->irq_context[MSIxIndex];
  3808			complete_cmd_fusion(instance, MSIxIndex, NULL);
  3809		}
  3810	}
  3811	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40551 bytes --]