From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Can Guo <cang@codeaurora.org>, Avri Altman <avri.altman@wdc.com>,
Bean Huo <beanhuo@micron.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Asutosh Das <asutoshd@codeaurora.org>
Subject: [PATCH v3 46/51] ufs: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
Date: Sun, 23 May 2021 20:08:51 -0700 [thread overview]
Message-ID: <20210524030856.2824-47-bvanassche@acm.org> (raw)
In-Reply-To: <20210524030856.2824-1-bvanassche@acm.org>
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/ufs/ufshcd.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c382260e0cf7..1fecba9eeb77 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -379,6 +379,8 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, unsigned int tag,
}
if (cmd) { /* data phase exists */
+ struct request *rq = scsi_cmd_to_rq(cmd);
+
/* trace UPIU also */
ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
opcode = cmd->cmnd[0];
@@ -387,17 +389,15 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, unsigned int tag,
* Currently we only fully trace read(10) and write(10)
* commands
*/
- if (cmd->request && cmd->request->bio)
- lba = cmd->request->bio->bi_iter.bi_sector;
+ if (rq->bio)
+ lba = rq->bio->bi_iter.bi_sector;
transfer_len = be32_to_cpu(
lrbp->ucd_req_ptr->sc.exp_data_transfer_len);
if (opcode == WRITE_10)
group_id = lrbp->cmd->cmnd[6];
} else if (opcode == UNMAP) {
- if (cmd->request) {
- lba = scsi_get_lba(cmd);
- transfer_len = blk_rq_bytes(cmd->request);
- }
+ lba = scsi_get_lba(cmd);
+ transfer_len = blk_rq_bytes(rq);
}
}
@@ -2058,7 +2058,7 @@ static void ufshcd_update_monitor(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
int dir = ufshcd_monitor_opcode2dir(*lrbp->cmd->cmnd);
if (dir >= 0 && hba->monitor.nr_queued[dir] > 0) {
- struct request *req = lrbp->cmd->request;
+ struct request *req = scsi_cmd_to_rq(lrbp->cmd);
struct ufs_hba_monitor *m = &hba->monitor;
ktime_t now, inc, lat;
@@ -2677,11 +2677,11 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
hba = shost_priv(host);
- tag = cmd->request->tag;
+ tag = scsi_cmd_to_rq(cmd)->tag;
if (!ufshcd_valid_tag(hba, tag)) {
dev_err(hba->dev,
- "%s: invalid command tag %d: cmd=0x%p, cmd->request=0x%p",
- __func__, tag, cmd, cmd->request);
+ "%s: invalid command tag %d: cmd=0x%p, scsi_cmd_to_rq=0x%p",
+ __func__, tag, cmd, scsi_cmd_to_rq(cmd));
BUG();
}
@@ -2716,7 +2716,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
lrbp->lun = ufshcd_scsi_to_upiu_lun(cmd->device->lun);
lrbp->intr_cmd = !ufshcd_is_intr_aggr_allowed(hba) ? true : false;
- ufshcd_prepare_lrbp_crypto(cmd->request, lrbp);
+ ufshcd_prepare_lrbp_crypto(scsi_cmd_to_rq(cmd), lrbp);
lrbp->req_abort_skip = false;
@@ -6965,12 +6965,12 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
host = cmd->device->host;
hba = shost_priv(host);
- tag = cmd->request->tag;
+ tag = scsi_cmd_to_rq(cmd)->tag;
lrbp = &hba->lrb[tag];
if (!ufshcd_valid_tag(hba, tag)) {
dev_err(hba->dev,
- "%s: invalid command tag %d: cmd=0x%p, cmd->request=0x%p",
- __func__, tag, cmd, cmd->request);
+ "%s: invalid command tag %d: cmd=0x%p, scsi_cmd_to_rq=0x%p",
+ __func__, tag, cmd, scsi_cmd_to_rq(cmd));
BUG();
}
next prev parent reply other threads:[~2021-05-24 3:10 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 3:08 [PATCH v3 00/51] Remove the request pointer from struct scsi_cmnd Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 01/51] core: Introduce the scsi_cmd_to_rq() function Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 02/51] core: Use scsi_cmd_to_rq() instead of scsi_cmnd.request Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 03/51] sd: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 04/51] sr: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 05/51] scsi_transport_fc: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 06/51] scsi_transport_spi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 07/51] ata: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 08/51] RDMA/iser: " Bart Van Assche
2021-05-24 8:46 ` Max Gurtovoy
2021-05-24 3:08 ` [PATCH v3 09/51] RDMA/srp: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 10/51] zfcp: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 11/51] 53c700: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 12/51] NCR5380: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 13/51] aacraid: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 14/51] advansys: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 15/51] aha1542: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 16/51] bnx2i: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 17/51] csiostor: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 18/51] cxlflash: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 19/51] dpt_i2o: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 20/51] fnic: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 21/51] hisi_sas: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 22/51] hpsa: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 23/51] ibmvfc: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 24/51] ibmvscsi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 25/51] ips: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 26/51] libsas: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 27/51] lpfc: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 28/51] megaraid: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 29/51] mpt3sas: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 30/51] mvumi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 31/51] myrb: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 32/51] myrs: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 33/51] ncr53c8xx: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 34/51] qedf: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 35/51] qedi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 36/51] qla1280: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 37/51] qla2xxx: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 38/51] qla4xxx: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 39/51] qlogicpti: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 40/51] scsi_debug: " Bart Van Assche
2021-05-25 16:19 ` Douglas Gilbert
2021-05-24 3:08 ` [PATCH v3 41/51] smartpqi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 42/51] snic: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 43/51] stex: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 44/51] sun3_scsi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 45/51] sym53c8xx: " Bart Van Assche
2021-05-24 3:08 ` Bart Van Assche [this message]
2021-05-24 3:08 ` [PATCH v3 47/51] virtio_scsi: " Bart Van Assche
2021-05-24 9:23 ` Michael S. Tsirkin
2021-05-24 3:08 ` [PATCH v3 48/51] xen-scsifront: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 49/51] tcm_loop: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 50/51] usb-storage: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 51/51] core: Remove the request member from struct scsi_cmnd Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524030856.2824-47-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox