From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.de>, Ming Lei <ming.lei@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: [PATCH v3 51/51] core: Remove the request member from struct scsi_cmnd
Date: Sun, 23 May 2021 20:08:56 -0700 [thread overview]
Message-ID: <20210524030856.2824-52-bvanassche@acm.org> (raw)
In-Reply-To: <20210524030856.2824-1-bvanassche@acm.org>
Since all scsi_cmnd.request users are gone, remove the request pointer
from struct scsi_cmnd.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/scsi_error.c | 1 -
drivers/scsi/scsi_lib.c | 1 -
include/scsi/scsi_cmnd.h | 3 ---
3 files changed, 5 deletions(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 5af6d87e83aa..3c83e892284b 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -2390,7 +2390,6 @@ scsi_ioctl_reset(struct scsi_device *dev, int __user *arg)
scmd = (struct scsi_cmnd *)(rq + 1);
scsi_init_command(dev, scmd);
- scmd->request = rq;
scmd->cmnd = scsi_req(rq)->cmd;
scmd->scsi_done = scsi_reset_provider_done_command;
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 2e9598c91cee..b5df3f94156e 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1536,7 +1536,6 @@ static blk_status_t scsi_prepare_cmd(struct request *req)
scsi_init_command(sdev, cmd);
- cmd->request = req;
cmd->tag = req->tag;
cmd->prot_op = SCSI_PROT_NORMAL;
if (blk_rq_bytes(req))
diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
index bd7f73f035be..984bfa5deab8 100644
--- a/include/scsi/scsi_cmnd.h
+++ b/include/scsi/scsi_cmnd.h
@@ -111,9 +111,6 @@ struct scsi_cmnd {
reconnects. Probably == sector
size */
- struct request *request; /* The command we are
- working on */
-
unsigned char *sense_buffer;
/* obtained by REQUEST SENSE when
* CHECK CONDITION is received on original
prev parent reply other threads:[~2021-05-24 3:10 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 3:08 [PATCH v3 00/51] Remove the request pointer from struct scsi_cmnd Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 01/51] core: Introduce the scsi_cmd_to_rq() function Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 02/51] core: Use scsi_cmd_to_rq() instead of scsi_cmnd.request Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 03/51] sd: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 04/51] sr: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 05/51] scsi_transport_fc: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 06/51] scsi_transport_spi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 07/51] ata: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 08/51] RDMA/iser: " Bart Van Assche
2021-05-24 8:46 ` Max Gurtovoy
2021-05-24 3:08 ` [PATCH v3 09/51] RDMA/srp: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 10/51] zfcp: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 11/51] 53c700: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 12/51] NCR5380: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 13/51] aacraid: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 14/51] advansys: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 15/51] aha1542: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 16/51] bnx2i: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 17/51] csiostor: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 18/51] cxlflash: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 19/51] dpt_i2o: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 20/51] fnic: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 21/51] hisi_sas: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 22/51] hpsa: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 23/51] ibmvfc: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 24/51] ibmvscsi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 25/51] ips: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 26/51] libsas: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 27/51] lpfc: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 28/51] megaraid: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 29/51] mpt3sas: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 30/51] mvumi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 31/51] myrb: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 32/51] myrs: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 33/51] ncr53c8xx: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 34/51] qedf: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 35/51] qedi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 36/51] qla1280: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 37/51] qla2xxx: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 38/51] qla4xxx: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 39/51] qlogicpti: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 40/51] scsi_debug: " Bart Van Assche
2021-05-25 16:19 ` Douglas Gilbert
2021-05-24 3:08 ` [PATCH v3 41/51] smartpqi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 42/51] snic: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 43/51] stex: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 44/51] sun3_scsi: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 45/51] sym53c8xx: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 46/51] ufs: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 47/51] virtio_scsi: " Bart Van Assche
2021-05-24 9:23 ` Michael S. Tsirkin
2021-05-24 3:08 ` [PATCH v3 48/51] xen-scsifront: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 49/51] tcm_loop: " Bart Van Assche
2021-05-24 3:08 ` [PATCH v3 50/51] usb-storage: " Bart Van Assche
2021-05-24 3:08 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524030856.2824-52-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox