From: Ming Lei <ming.lei@redhat.com>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: Ming Lei <ming.lei@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
John Garry <john.garry@huawei.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 4/4] scsi: core: only put parent device if host state isn't in SHOST_CREATED
Date: Wed, 2 Jun 2021 21:30:29 +0800 [thread overview]
Message-ID: <20210602133029.2864069-5-ming.lei@redhat.com> (raw)
In-Reply-To: <20210602133029.2864069-1-ming.lei@redhat.com>
get_device(shost->shost_gendev.parent) is called after host state is
changed to SHOST_RUNNING. So scsi_host_dev_release() shouldn't release
the parent device if host state is still SHOST_CREATED.
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
drivers/scsi/hosts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 7049844adb6b..34db5be7a562 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -350,7 +350,7 @@ static void scsi_host_dev_release(struct device *dev)
ida_simple_remove(&host_index_ida, shost->host_no);
- if (parent)
+ if (shost->shost_state != SHOST_CREATED)
put_device(parent);
kfree(shost);
}
--
2.29.2
next prev parent reply other threads:[~2021-06-02 13:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 13:30 [PATCH 0/4] scsi: fix failure handling of alloc/add host Ming Lei
2021-06-02 13:30 ` [PATCH 1/4] scsi: core: fix error handling of scsi_host_alloc Ming Lei
2021-06-03 2:26 ` Bart Van Assche
2021-06-03 15:40 ` John Garry
2021-06-07 11:39 ` Hannes Reinecke
2021-06-29 19:23 ` Tyrel Datwyler
2021-06-30 0:11 ` Ming Lei
2021-06-02 13:30 ` [PATCH 2/4] scsi: core: fix failure handling of scsi_add_host_with_dma Ming Lei
2021-06-03 2:32 ` Bart Van Assche
2021-06-03 15:40 ` John Garry
2021-06-07 11:37 ` Hannes Reinecke
2021-06-02 13:30 ` [PATCH 3/4] scsi: core: put .shost_dev in failure path if host state becomes running Ming Lei
2021-06-03 3:06 ` Bart Van Assche
2021-06-03 3:22 ` Ming Lei
2021-06-03 15:41 ` John Garry
2021-06-07 11:40 ` Hannes Reinecke
2021-06-02 13:30 ` Ming Lei [this message]
2021-06-03 3:08 ` [PATCH 4/4] scsi: core: only put parent device if host state isn't in SHOST_CREATED Bart Van Assche
2021-06-03 15:38 ` John Garry
2021-06-07 11:41 ` Hannes Reinecke
2021-06-07 11:56 ` Ming Lei
2021-06-03 15:43 ` [PATCH 0/4] scsi: fix failure handling of alloc/add host John Garry
2021-06-08 3:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602133029.2864069-5-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).