From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7CFC11F6B for ; Sat, 10 Jul 2021 02:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAF5B613C9 for ; Sat, 10 Jul 2021 02:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233965AbhGJCgb (ORCPT ); Fri, 9 Jul 2021 22:36:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233819AbhGJCfZ (ORCPT ); Fri, 9 Jul 2021 22:35:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 044AA61411; Sat, 10 Jul 2021 02:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625884344; bh=bE/IdGLh2cA14qDebd7mCLahEZQLYxLcg+ksd9ACITg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qi8EJ71nAg6s8gBirqaQsOAkBYrXM57IBGVHaIhxfG+jxBiaaEtB7r1q6rOquwSwz vAMJM4g3EXqCXXlrqCWP393upfQ6QmqoXeFs8Z4AP6wx0SmoLURTRoXLBPRLgZLyFY 8uAmjWLwZ2EjvRi++4T6SQPc4d1Y8uiEhifNChzrhH6xTiYi1/QoqU8RibH3d4/7yq Q6ajbQf1QXnGBfrrSfnACIE2T0UC/BQ1rEwr6GkAZ2T9ci5TNWTANHTWffvpSLTH9L 2iRtb/1DiqFYTi6xylDC2vyHaR7suTwbl9BcpTqahFE0IsFKtJxYnPaQrvRzaI1Wp0 Tg0K+7VSff9OA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mike Christie , Manish Rangankar , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 16/39] scsi: qedi: Fix null ref during abort handling Date: Fri, 9 Jul 2021 22:31:41 -0400 Message-Id: <20210710023204.3171428-16-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710023204.3171428-1-sashal@kernel.org> References: <20210710023204.3171428-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Mike Christie [ Upstream commit 5777b7f0f03ce49372203b6521631f62f2810c8f ] If qedi_process_cmd_cleanup_resp finds the cmd it frees the work and sets list_tmf_work to NULL, so qedi_tmf_work should check if list_tmf_work is non-NULL when it wants to force cleanup. Link: https://lore.kernel.org/r/20210525181821.7617-20-michael.christie@oracle.com Reviewed-by: Manish Rangankar Signed-off-by: Mike Christie Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qedi/qedi_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c index 357a0acc5ed2..b60b48f3b984 100644 --- a/drivers/scsi/qedi/qedi_fw.c +++ b/drivers/scsi/qedi/qedi_fw.c @@ -1466,7 +1466,7 @@ static void qedi_tmf_work(struct work_struct *work) ldel_exit: spin_lock_bh(&qedi_conn->tmf_work_lock); - if (!qedi_cmd->list_tmf_work) { + if (qedi_cmd->list_tmf_work) { list_del_init(&list_work->list); qedi_cmd->list_tmf_work = NULL; kfree(list_work); -- 2.30.2