From: David Disseldorp <ddiss@suse.de>
To: Sergey Samoylenko <s.samoylenko@yadro.com>
Cc: <martin.petersen@oracle.com>, <michael.christie@oracle.com>,
<target-devel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux@yadro.com>
Subject: Re: [PATCH 0/1] scsi: target: core: Fix sense key for invalid XCOPY request
Date: Wed, 21 Jul 2021 23:45:05 +0200 [thread overview]
Message-ID: <20210721234505.45c93a48@suse.de> (raw)
In-Reply-To: <20210624111926.63176-1-s.samoylenko@yadro.com>
Hi Sergey,
On Thu, 24 Jun 2021 14:19:25 +0300, Sergey Samoylenko wrote:
> EXTENDED COPY tests in libiscsi [1] show that TCM doesn't
> follow SPC4 when detects invalid parameters in a XCOPY
> command or IO errors. The replies from TCM contain wrong sense
> key or ASCQ for incorrect request.
>
> The series fixes the following tests from libiscsi:
We've hit this too. The incorrect sense reporting appears to also affect
VMware XCOPY fallback to initiator driven READ/WRITE. I'm pretty sure
this is a regression from d877d7275be34ad70ce92bcbb4bb36cec77ed004, so
should probably be marked as such via a Fixes tag.
Cheers, David
next prev parent reply other threads:[~2021-07-21 21:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 11:19 [PATCH 0/1] scsi: target: core: Fix sense key for invalid XCOPY request Sergey Samoylenko
2021-06-24 11:19 ` [PATCH 1/1] " Sergey Samoylenko
2021-06-24 15:49 ` kernel test robot
2021-06-24 15:57 ` Bart Van Assche
2021-06-24 17:27 ` Sergey Samoylenko
2021-07-21 21:45 ` David Disseldorp [this message]
2021-07-22 11:03 ` [PATCH 0/1] " Sergey Samoylenko
2021-07-22 13:27 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721234505.45c93a48@suse.de \
--to=ddiss@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=s.samoylenko@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox