From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 516F4C4338F for ; Thu, 5 Aug 2021 13:33:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 312D06113C for ; Thu, 5 Aug 2021 13:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241105AbhHENdS (ORCPT ); Thu, 5 Aug 2021 09:33:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239373AbhHENdR (ORCPT ); Thu, 5 Aug 2021 09:33:17 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60070C061765; Thu, 5 Aug 2021 06:33:03 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id d6so8386499edt.7; Thu, 05 Aug 2021 06:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5KnmBsMekLsd2KwbsCS76Z4wO/OCvggDPwW2Gn92Ahw=; b=M+Mo3cGpJOMX18N6LDI1LAyw7SvwYwAAxW2/b5IQcqeDKiFV3D1yniW86DRuabe95M ZwexJyeLi4cSWMz/8IzinGKVuCQ6LapSRhjiYHRhVmuPAGmkCkLfV2cCks1i/tKotVDK tSh3i8nyKsuJ6wsDaP1czISWsff7gPfGLNCss8Sr5taIKQznhRV4kZN5OP2+wzdYXbdx brSEEYpyh+Y+M2YR63u6gQ41NMTRr8Dg6a6anUG3c9L5FVbXOVFJbSnOYWAZKnyBd2F9 R/Hr3bp3jk8a9ZB4BzvyXFtfJZjcyJ/0oceL7BfQliuPP4NeGMyqUUi3KxqMoISmE1q6 W6Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5KnmBsMekLsd2KwbsCS76Z4wO/OCvggDPwW2Gn92Ahw=; b=TcQTJPiQKZk56OJUnki6qMj342MlR7dCJWumlGbSfeCi/b9QVbrGaBFvs2ER17CLdC yih4p5VE437yQQN09eLfi7HvvlMxG4sG69VXzIA3pACl5fZl/hGmE0UqHCRP73iwXlTm /Sf0qJMeRBKxnbnVRNd3c6Mu99RBoMB0g5PzsRRpyLAiqyd15E0AeS5j1FUKNA6aVefv upG+eCYd15t3CbJiVVYMPu0J5QAZQafxqV4s7TvNUHW+DKreo92nYGkIq3rtaxle4WZ9 lvqP6cUBrYg6GLdyGmkmuauXrLCsWLB5Jp8eFKcrkfQ86fxyDbCQzNPfqrdef/FlcntQ eFmA== X-Gm-Message-State: AOAM532ZOyI2Ei5Qn2QmfK8NbYdj3OiVA7XaBw7RpbBo7U/N/GqnExCP BlFhx2LCXQtfO1tWbZ/FvFk= X-Google-Smtp-Source: ABdhPJy8m29nLG+tfWs5oWsDoLeffEefb1XumC1J2kldxf7KmM/8mwma+wQMLr7MKklhYfK2aA4PUg== X-Received: by 2002:a05:6402:b19:: with SMTP id bm25mr6658537edb.213.1628170382003; Thu, 05 Aug 2021 06:33:02 -0700 (PDT) Received: from skbuf ([188.25.144.60]) by smtp.gmail.com with ESMTPSA id df14sm2294248edb.90.2021.08.05.06.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 06:33:01 -0700 (PDT) Date: Thu, 5 Aug 2021 16:32:58 +0300 From: Vladimir Oltean To: Arnd Bergmann Cc: "David S. Miller" , Jakub Kicinski , Richard Cochran , Arnd Bergmann , Shannon Nelson , Jacob Keller , Andrew Lunn , Vivien Didelot , Florian Fainelli , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Nicolas Ferre , Claudiu Beznea , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jiri Pirko , Ido Schimmel , drivers@pensando.io, Sergei Shtylyov , Edward Cree , Martin Habets , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Yangbo Lu , Karen Xie , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH net-next v4] ethernet: fix PTP_1588_CLOCK dependencies Message-ID: <20210805133258.zvhn5kznjt7taqyu@skbuf> References: <20210805082253.3654591-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210805082253.3654591-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Thu, Aug 05, 2021 at 10:13:57AM +0200, Arnd Bergmann wrote: > diff --git a/drivers/net/dsa/mv88e6xxx/Kconfig b/drivers/net/dsa/mv88e6xxx/Kconfig > index 634a48e6616b..7a2445a34eb7 100644 > --- a/drivers/net/dsa/mv88e6xxx/Kconfig > +++ b/drivers/net/dsa/mv88e6xxx/Kconfig > @@ -2,6 +2,7 @@ > config NET_DSA_MV88E6XXX > tristate "Marvell 88E6xxx Ethernet switch fabric support" > depends on NET_DSA > + depends on PTP_1588_CLOCK_OPTIONAL > select IRQ_DOMAIN > select NET_DSA_TAG_EDSA > select NET_DSA_TAG_DSA > diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig > index 932b6b6fe817..9948544ba1c4 100644 > --- a/drivers/net/dsa/ocelot/Kconfig > +++ b/drivers/net/dsa/ocelot/Kconfig > @@ -5,6 +5,7 @@ config NET_DSA_MSCC_FELIX > depends on NET_VENDOR_MICROSEMI > depends on NET_VENDOR_FREESCALE > depends on HAS_IOMEM > + depends on PTP_1588_CLOCK_OPTIONAL > select MSCC_OCELOT_SWITCH_LIB > select NET_DSA_TAG_OCELOT_8021Q > select NET_DSA_TAG_OCELOT > @@ -19,6 +20,7 @@ config NET_DSA_MSCC_SEVILLE > depends on NET_DSA > depends on NET_VENDOR_MICROSEMI > depends on HAS_IOMEM > + depends on PTP_1588_CLOCK_OPTIONAL > select MSCC_OCELOT_SWITCH_LIB > select NET_DSA_TAG_OCELOT_8021Q > select NET_DSA_TAG_OCELOT > diff --git a/drivers/net/dsa/sja1105/Kconfig b/drivers/net/dsa/sja1105/Kconfig > index b29d41e5e1e7..1291bba3f3b6 100644 > --- a/drivers/net/dsa/sja1105/Kconfig > +++ b/drivers/net/dsa/sja1105/Kconfig > @@ -2,6 +2,7 @@ > config NET_DSA_SJA1105 > tristate "NXP SJA1105 Ethernet switch family support" > depends on NET_DSA && SPI > + depends on PTP_1588_CLOCK_OPTIONAL > select NET_DSA_TAG_SJA1105 > select PCS_XPCS > select PACKING > diff --git a/drivers/net/ethernet/mscc/Kconfig b/drivers/net/ethernet/mscc/Kconfig > index 2d3157e4d081..b07912434560 100644 > --- a/drivers/net/ethernet/mscc/Kconfig > +++ b/drivers/net/ethernet/mscc/Kconfig > @@ -13,6 +13,7 @@ if NET_VENDOR_MICROSEMI > > # Users should depend on NET_SWITCHDEV, HAS_IOMEM, BRIDGE > config MSCC_OCELOT_SWITCH_LIB > + depends on PTP_1588_CLOCK_OPTIONAL No, don't make the MSCC_OCELOT_SWITCH_LIB depend on anything please, since it is always "select"-ed, it shouldn't have dependencies, see the comment above. If you want, add this to the comment: "Users should depend on (...), PTP_1588_CLOCK_OPTIONAL". > select NET_DEVLINK > select REGMAP_MMIO > select PACKING > @@ -24,6 +25,7 @@ config MSCC_OCELOT_SWITCH_LIB > > config MSCC_OCELOT_SWITCH > tristate "Ocelot switch driver" > + depends on PTP_1588_CLOCK_OPTIONAL > depends on BRIDGE || BRIDGE=n > depends on NET_SWITCHDEV > depends on HAS_IOMEM > @@ -253,6 +254,7 @@ config NATIONAL_PHY > > config NXP_C45_TJA11XX_PHY > tristate "NXP C45 TJA11XX PHYs" > + depends on PTP_1588_CLOCK_OPTIONAL > help > Enable support for NXP C45 TJA11XX PHYs. > Currently supports only the TJA1103 PHY. With that changed: Reviewed-by: Vladimir Oltean