From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH] scsi: core: cleanup request queue before releasing gendisk
Date: Fri, 17 Sep 2021 14:37:19 +0200 [thread overview]
Message-ID: <20210917123719.GA17003@lst.de> (raw)
In-Reply-To: <YURSj0G5gMiSAo5j@T590.Home>
On Fri, Sep 17, 2021 at 04:32:15PM +0800, Ming Lei wrote:
> > Is it? For the typical case the second free in blk_cleanp_queue will
> > be bsically free because there is no pending I/O. The only case
> > where that matters if if there is pending passthrough I/O again,
> > which can only happen with SCSI, and even there is highly unusual.
>
> RCU grace period is involved in blk_freeze_queue().
where?
> One way you can
> avoid it is to keep the percpu ref at atomic mode when running
> blk_mq_unfreeze_queue() in del_gendisk().
>
>
>
> Thanks,
> Ming
---end quoted text---
next prev parent reply other threads:[~2021-09-17 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 9:25 [PATCH] scsi: core: cleanup request queue before releasing gendisk Ming Lei
2021-09-15 13:40 ` Christoph Hellwig
2021-09-16 1:36 ` Ming Lei
2021-09-16 10:14 ` Christoph Hellwig
2021-09-16 12:38 ` Ming Lei
2021-09-16 14:20 ` Christoph Hellwig
2021-09-17 3:39 ` Ming Lei
2021-09-17 6:53 ` Christoph Hellwig
2021-09-17 7:41 ` Ming Lei
2021-09-17 7:56 ` Christoph Hellwig
2021-09-17 8:32 ` Ming Lei
2021-09-17 12:37 ` Christoph Hellwig [this message]
2021-09-17 13:41 ` Ming Lei
2021-09-15 13:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917123719.GA17003@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox