Re: [PATCH] scsi: core: Remove include from scsi_cmnd.h

Himanshu Madhani
2021-09-20T14:01:31Z

> On Sep 17, 2021, at 4:27 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>
> There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h>
> header file. Hence remove the scsi_host.h include directive from
> scsi_cmnd.h. This include directive was introduced in February 2021 by
> commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").
>
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> include/scsi/scsi_cmnd.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
> index eaf04c9a1dfc..a2315aac93c7 100644
> --- a/include/scsi/scsi_cmnd.h
> +++ b/include/scsi/scsi_cmnd.h
> @@ -10,7 +10,6 @@
> #include <linux/timer.h>
> #include <linux/scatterlist.h>
> #include <scsi/scsi_device.h>
> -#include <scsi/scsi_host.h>
> #include <scsi/scsi_request.h>
>
> struct Scsi_Host;

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani Oracle Linux Engineering