* [PATCH] scsi: efct: Delete stray unlock statement
@ 2021-10-04 10:38 Dan Carpenter
2021-10-05 4:33 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-10-04 10:38 UTC (permalink / raw)
To: James Smart
Cc: Ram Vegesna, James E.J. Bottomley, Martin K. Petersen,
Hannes Reinecke, Daniel Wagner, Dmitry Bogdanov, linux-scsi,
target-devel, kernel-janitors
It's not holding the lock at this stage and the IRQ "flags" are not
correct so it would restore something bogus. Delete the unlock
statement.
Fixes: 3e6414003bf9 ("scsi: elx: efct: SCSI I/O handling routines")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/elx/efct/efct_scsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/elx/efct/efct_scsi.c b/drivers/scsi/elx/efct/efct_scsi.c
index 8535bb7eabd8..afb154992053 100644
--- a/drivers/scsi/elx/efct/efct_scsi.c
+++ b/drivers/scsi/elx/efct/efct_scsi.c
@@ -32,7 +32,7 @@ efct_scsi_io_alloc(struct efct_node *node)
struct efct *efct;
struct efct_xport *xport;
struct efct_io *io;
- unsigned long flags = 0;
+ unsigned long flags;
efct = node->efct;
@@ -42,7 +42,6 @@ efct_scsi_io_alloc(struct efct_node *node)
if (!io) {
efc_log_err(efct, "IO alloc Failed\n");
atomic_add_return(1, &xport->io_alloc_failed_count);
- spin_unlock_irqrestore(&node->active_ios_lock, flags);
return NULL;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: efct: Delete stray unlock statement
2021-10-04 10:38 [PATCH] scsi: efct: Delete stray unlock statement Dan Carpenter
@ 2021-10-05 4:33 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-10-05 4:33 UTC (permalink / raw)
To: James Smart, Dan Carpenter
Cc: Martin K . Petersen, Hannes Reinecke, linux-scsi, Daniel Wagner,
target-devel, kernel-janitors, James E.J. Bottomley, Ram Vegesna,
Dmitry Bogdanov
On Mon, 4 Oct 2021 13:38:51 +0300, Dan Carpenter wrote:
> It's not holding the lock at this stage and the IRQ "flags" are not
> correct so it would restore something bogus. Delete the unlock
> statement.
>
>
Applied to 5.15/scsi-fixes, thanks!
[1/1] scsi: efct: Delete stray unlock statement
https://git.kernel.org/mkp/scsi/c/a013c71c6315
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-05 4:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-04 10:38 [PATCH] scsi: efct: Delete stray unlock statement Dan Carpenter
2021-10-05 4:33 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox