From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC84EC433F5 for ; Wed, 13 Oct 2021 06:16:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A048060C4D for ; Wed, 13 Oct 2021 06:16:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237909AbhJMGSS (ORCPT ); Wed, 13 Oct 2021 02:18:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237918AbhJMGSQ (ORCPT ); Wed, 13 Oct 2021 02:18:16 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E511C061768 for ; Tue, 12 Oct 2021 23:16:13 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id r2so1296494pgl.10 for ; Tue, 12 Oct 2021 23:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FeQrChfiZcW4o0OhHTmPDOdTdbcOGCmUWNGR2fssds0=; b=YUuG6H1i9AjWoYvXd657AlnL8Btrj3iAYL/kBUykjBQlXgbXqBCSYgFqW+ybNjzAeB flHfU7/d2gVIiRxHZf0let0/mE+C7OG46tBNBXIlx9AYwOAntMTNFSW889cvlMxABatE ibs+ClrRJ9QM6AUZ6rkBA4X98UUtvKEjHgCX4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FeQrChfiZcW4o0OhHTmPDOdTdbcOGCmUWNGR2fssds0=; b=eWdL41S9J/B7/2K/va7ACFp332b9zdC12E6I13dyCnSYBwz3IBV6VImxucKFlMzmJo BtsvntcmL+HBtPL983egg1g/ezLJQVnpG3XkE7fsqh+KNTCD3CGDxmZz8/R2qigD2NNh jAQeuP9IzBKME6YvB/nCBVhPDZHoU5+4FuIHSnCLCFypP1O70APKOq+3djaP9FW2fAXc H4SdYoaXFMUwkVXJfncR4+8M/f0kS0jgPKRDxku2crKN2XS4IZnPtmQbh5GWY2wVej+w fz4ZT1F7o6MgGjXu8KM960myyT63vL2ugdTIO+J5RYsF6frJzTl9y0L+YXHyZewkBdzE b6EQ== X-Gm-Message-State: AOAM532y9qRexJxHZx2PMOBlX5tyFi51zqao8Z/t1cqgEiiK643Xk2Lp R/bsqvNFrYyMfCMioVElZkmHuQ== X-Google-Smtp-Source: ABdhPJwmuFRgBzGEKwhfH80cvrnOY6Q3ng7kI1vOHwrwBDvns1KKcyGoScUlnacdxAU8v7fqrhUUVw== X-Received: by 2002:a63:d654:: with SMTP id d20mr26275164pgj.122.1634105772620; Tue, 12 Oct 2021 23:16:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a28sm13085937pfg.33.2021.10.12.23.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:16:12 -0700 (PDT) Date: Tue, 12 Oct 2021 23:16:11 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 12/29] cramfs: use bdev_nr_sectors instead of open coding it Message-ID: <202110122315.7CFF5F6@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-13-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-13-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Oct 13, 2021 at 07:10:25AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig > --- > fs/cramfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c > index 2be65269a987c..3e44cc3ed0543 100644 > --- a/fs/cramfs/inode.c > +++ b/fs/cramfs/inode.c > @@ -209,7 +209,7 @@ static void *cramfs_blkdev_read(struct super_block *sb, unsigned int offset, > return read_buffers[i] + blk_offset; > } > > - devsize = mapping->host->i_size >> PAGE_SHIFT; > + devsize = bdev_nr_sectors(sb->s_bdev) >> (PAGE_SHIFT - SECTOR_SHIFT); I find this less readable than "bytes >> PAGE_SHIFT". I'd suggest this use a new bdev_nr_bytes() helper. -- Kees Cook