Re: [PATCH 2/2] scsi: target: iblock: Report space allocation errors

Mike Christie
2023-05-20T18:05:16Z

On 5/17/23 9:15 AM, Konstantin Shelekhin wrote:
> When a thin provisioned block device lacks free LBA it ends bio requests
> with BLK_STS_NOSPC. Currently iblock treats bio status as a boolean and
> terminates failed requests with LOGICAL UNIT COMMUNICATION FAILURE if
> the status is non-zero. Thus, initiators see space allocation errors as
> I/O errors.
>
> This commit modifies the iblock_req structure to store the status of the
> first failed bio instead of the total number of failed bios. The status
> is then used to set the specific sense reason.
>

You posted this patch before right? I think it didn't get picked up because
the kernel bot keeps flagging the mixing of the blk_status_t and atomic_t.
Just build with sparse C=1 and you should see it.