Re: [PATCH v2 12/13] block: make __register_blkdev() return an error

Christoph Hellwig
2021-11-03T17:00:56Z

On Wed, Nov 03, 2021 at 09:44:53AM -0700, Luis Chamberlain wrote:
> Here's the thing, prober call a form of add_disk(), and so do we want
> to always ignore the errors on probe? If so we should document why that
> is sane then. I think this approach is a bit more sane though.

I suspect the right thing is to just kill of ->probe.

The only thing it supports is pre-devtmpfs, pre-udev semantics that
want to magically create disks when their pre-created device node
is accesses. But if we don't remove it, yes I think not reporting
the error is best. Just clean up whatever local resources were set
up in the ->probe method and let the open fail without the need of
passing on the actual error.