Re: [PATCH v2 06/20] scsi: core: Add support for reserved tags

Bart Van Assche
2021-11-22T17:25:42Z

On 11/22/21 12:15 AM, John Garry wrote:
> On 19/11/2021 19:57, Bart Van Assche wrote:
>> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
>> index 72e1a347baa6..ec0f7705e06a 100644
>> --- a/include/scsi/scsi_host.h
>> +++ b/include/scsi/scsi_host.h
>> @@ -367,10 +367,17 @@ struct scsi_host_template {
>
> why no field in struct Scsi_Host?

Why to duplicate this field in struct Scsi_Host? Do we expect that there
will be SCSI drivers in the future for which the number of reserved tags
is only known at runtime? This seems unlikely to me.

>> +    unsigned reserved_tags;
>
> I thought that unsigned int was preferred

I will change 'unsigned' into 'unsigned int'.

Bart.