From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Ashokkumar N <Ashokkumar.N@microchip.com>,
kernel test robot <lkp@intel.com>,
Radha Ramachandran <radha@google.com>,
Viswas G <Viswas.G@microchip.com>
Subject: [PATCH 11/13] scsi: pm8001: Fix kernel-doc warnings
Date: Tue, 23 Nov 2021 16:52:15 -0800 [thread overview]
Message-ID: <20211124005217.2300458-12-bvanassche@acm.org> (raw)
In-Reply-To: <20211124005217.2300458-1-bvanassche@acm.org>
Fix the following kernel-doc warnings:
drivers/scsi/pm8001/pm8001_ctl.c:900: warning: cannot understand function prototype: 'const char *const mpiStateText[] = '
drivers/scsi/pm8001/pm8001_ctl.c:930: warning: Function parameter or member 'attr' not described in 'ctl_hmi_error_show'
drivers/scsi/pm8001/pm8001_ctl.c:951: warning: Function parameter or member 'attr' not described in 'ctl_raae_count_show'
drivers/scsi/pm8001/pm8001_ctl.c:972: warning: Function parameter or member 'attr' not described in 'ctl_iop0_count_show'
drivers/scsi/pm8001/pm8001_ctl.c:993: warning: Function parameter or member 'attr' not described in 'ctl_iop1_count_show'
Fixes: 4ddbea1b6f51 ("scsi: pm80xx: Add sysfs attribute to check MPI state")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/pm8001/pm8001_ctl.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
index 397eb9f6a1dd..41a63c9b719b 100644
--- a/drivers/scsi/pm8001/pm8001_ctl.c
+++ b/drivers/scsi/pm8001/pm8001_ctl.c
@@ -889,14 +889,6 @@ static ssize_t pm8001_show_update_fw(struct device *cdev,
static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUSR|S_IWGRP,
pm8001_show_update_fw, pm8001_store_update_fw);
-/**
- * ctl_mpi_state_show - controller MPI state check
- * @cdev: pointer to embedded class device
- * @buf: the buffer returned
- *
- * A sysfs 'read-only' shost attribute.
- */
-
static const char *const mpiStateText[] = {
"MPI is not initialized",
"MPI is successfully initialized",
@@ -904,6 +896,14 @@ static const char *const mpiStateText[] = {
"MPI initialization failed with error in [31:16]"
};
+/**
+ * ctl_mpi_state_show - controller MPI state check
+ * @cdev: pointer to embedded class device
+ * @attr: device attribute (unused)
+ * @buf: the buffer returned
+ *
+ * A sysfs 'read-only' shost attribute.
+ */
static ssize_t ctl_mpi_state_show(struct device *cdev,
struct device_attribute *attr, char *buf)
{
@@ -920,11 +920,11 @@ static DEVICE_ATTR_RO(ctl_mpi_state);
/**
* ctl_hmi_error_show - controller MPI initialization fails
* @cdev: pointer to embedded class device
+ * @attr: device attribute (unused)
* @buf: the buffer returned
*
* A sysfs 'read-only' shost attribute.
*/
-
static ssize_t ctl_hmi_error_show(struct device *cdev,
struct device_attribute *attr, char *buf)
{
@@ -941,11 +941,11 @@ static DEVICE_ATTR_RO(ctl_hmi_error);
/**
* ctl_raae_count_show - controller raae count check
* @cdev: pointer to embedded class device
+ * @attr: device attribute (unused)
* @buf: the buffer returned
*
* A sysfs 'read-only' shost attribute.
*/
-
static ssize_t ctl_raae_count_show(struct device *cdev,
struct device_attribute *attr, char *buf)
{
@@ -962,11 +962,11 @@ static DEVICE_ATTR_RO(ctl_raae_count);
/**
* ctl_iop0_count_show - controller iop0 count check
* @cdev: pointer to embedded class device
+ * @attr: device attribute (unused)
* @buf: the buffer returned
*
* A sysfs 'read-only' shost attribute.
*/
-
static ssize_t ctl_iop0_count_show(struct device *cdev,
struct device_attribute *attr, char *buf)
{
@@ -983,11 +983,11 @@ static DEVICE_ATTR_RO(ctl_iop0_count);
/**
* ctl_iop1_count_show - controller iop1 count check
* @cdev: pointer to embedded class device
+ * @attr: device attribute (unused)
* @buf: the buffer returned
*
* A sysfs 'read-only' shost attribute.
*/
-
static ssize_t ctl_iop1_count_show(struct device *cdev,
struct device_attribute *attr, char *buf)
{
next prev parent reply other threads:[~2021-11-24 0:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 0:52 [PATCH 00/13] A series of small SCSI patches Bart Van Assche
2021-11-24 0:52 ` [PATCH 01/13] scsi: core: Suppress a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 02/13] scsi: core: Declare 'scsi_scan_type' static Bart Van Assche
2021-11-24 0:52 ` [PATCH 03/13] scsi: core: Show SCMD_LAST in text form Bart Van Assche
2021-11-24 0:52 ` [PATCH 04/13] scsi: a100u2w: Fix a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 05/13] scsi: ata: Declare 'ata_ncq_sdev_attrs' static Bart Van Assche
2021-11-24 8:54 ` Damien Le Moal
2021-11-29 19:37 ` Bart Van Assche
2021-11-24 0:52 ` [PATCH 06/13] scsi: atp870u: Fix a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 07/13] scsi: bfa: Declare 'bfad_im_vport_attrs' static Bart Van Assche
2021-11-24 0:52 ` [PATCH 08/13] scsi: dc395x: Fix a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 09/13] scsi: initio: " Bart Van Assche
2021-11-24 0:52 ` [PATCH 10/13] scsi: megaraid: " Bart Van Assche
2021-11-24 0:52 ` Bart Van Assche [this message]
2021-11-24 6:08 ` [PATCH 11/13] scsi: pm8001: Fix kernel-doc warnings Jinpu Wang
2021-11-24 0:52 ` [PATCH 12/13] scsi: pmcraid: Fix a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 13/13] scsi: Remove superfluous #include <linux/async.h> directives Bart Van Assche
2021-11-24 1:54 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124005217.2300458-12-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=Ashokkumar.N@microchip.com \
--cc=Viswas.G@microchip.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=radha@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox