From: Christoph Hellwig <hch@lst.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Jackie Liu <liuyun01@kylinos.cn>
Subject: Re: [PATCH] scsi: bsg: Ignore bsg queue registration failures again
Date: Thu, 23 Dec 2021 07:34:46 +0100 [thread overview]
Message-ID: <20211223063446.GA4005@lst.de> (raw)
In-Reply-To: <20211222165427.1855582-1-linux@roeck-us.net>
On Wed, Dec 22, 2021 at 08:54:27AM -0800, Guenter Roeck wrote:
> Since commit 5f7cf82c1d73 ("scsi: bsg: Fix errno when
> scsi_bsg_register_queue() fails"), errors from registering the bsg queue
> are no longer ignored but returned to the caller. At the same time, the
> comment in the code still states that errors are ignored. On top of that,
> the message preporting the problem is printed as dev_info, not dev_err.
> Both suggest that errors from bsg queue registrations should indeed be
> ignored.
But there is no good reason to ignore it. The proper fix is to fully
handle the errors.
prev parent reply other threads:[~2021-12-23 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 16:54 [PATCH] scsi: bsg: Ignore bsg queue registration failures again Guenter Roeck
2021-12-23 6:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223063446.GA4005@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=liuyun01@kylinos.cn \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).