linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Song Liu <song@kernel.org>
To: <linux-block@vger.kernel.org>, <linux-scsi@vger.kernel.org>
Cc: <kernel-team@fb.com>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>, <axboe@kernel.dk>, <hare@suse.de>,
	Song Liu <song@kernel.org>
Subject: [PATCH v2 0/3] block: scsi: introduce and use BLK_STS_OFFLINE
Date: Thu, 3 Feb 2022 11:28:24 -0800	[thread overview]
Message-ID: <20220203192827.1370270-1-song@kernel.org> (raw)

Changes v1 => v2:
1. Add patch 2/3 to change user visible return value to -ENODEV. (Hannes)
2. In the commit log, explain the reason to keep EIO in 1/3.

We have a use case where HDDs are regularly power on/off to perserve power.
When a drive is being removed, we often see errors like

   [  172.803279] I/O error, dev sda, sector 3137184

These messages are confusing for automations that grep dmesg, as they look
very similar to real HDD error.

Solve this issue with a new block state BLK_STS_OFFLINE. After the change,
the error message looks like

   [  172.803279] device offline error, dev sda, sector 3137184

so that the automations won't confuse them with real I/O error.

Song Liu (3):
  block: introduce BLK_STS_OFFLINE
  block: return -ENODEV for BLK_STS_OFFLINE
  scsi: use BLK_STS_OFFLINE for not fully online devices

 block/blk-core.c          | 1 +
 drivers/scsi/scsi_lib.c   | 2 +-
 include/linux/blk_types.h | 7 +++++++
 3 files changed, 9 insertions(+), 1 deletion(-)

--
2.30.2

             reply	other threads:[~2022-02-03 19:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-03 19:28 Song Liu [this message]
2022-02-03 19:28 ` [PATCH v2 1/3] block: introduce BLK_STS_OFFLINE Song Liu
2022-02-04  7:25   ` Hannes Reinecke
2022-02-03 19:28 ` [PATCH v2 2/3] block: return -ENODEV for BLK_STS_OFFLINE Song Liu
2022-02-04  7:26   ` Hannes Reinecke
2022-02-03 19:28 ` [PATCH v2 3/3] scsi: use BLK_STS_OFFLINE for not fully online devices Song Liu
2022-02-04  3:16 ` [PATCH v2 0/3] block: scsi: introduce and use BLK_STS_OFFLINE Martin K. Petersen
2022-02-04  4:10 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220203192827.1370270-1-song@kernel.org \
    --to=song@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).