From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v2 00/44] Remove the SCSI pointer from struct scsi_cmnd
Date: Tue, 8 Feb 2022 09:24:30 -0800 [thread overview]
Message-ID: <20220208172514.3481-1-bvanassche@acm.org> (raw)
Hi Martin,
The size of struct scsi_cmnd matters for embedded devices. One of the
largest members of that structure is the SCSI pointer. That structure is
only relevant for SCSI-II drivers but not for modern SCSI drivers. Hence
this patch series that removes the SCSI pointer from struct scsi_cmnd and
moves it into driver-private command data.
Please consider this patch series for kernel v5.18.
Thanks,
Bart.
Changes compared to v1:
- Removed BUILD_BUG_ON(sizeof(...) > sizeof(struct scsi_pointer)) statements.
- Added two void casts in front of I/O statements as requested by Johannes.
- Improved source code formatting in the aha152x driver.
- Restored the DID_OK constant in a SCSI result expression.
- Updated Reviewed-by tags.
Bart Van Assche (44):
ips: Use true and false instead of TRUE and FALSE
nsp_cs: Use true and false instead of TRUE and FALSE
scsi: Remove drivers/scsi/scsi.h
NCR5380: Remove the NCR5380_CMD_SIZE macro
NCR5380: Move the SCSI pointer to private command data
scsi: arm: Rename arm/scsi.h into arm/arm_scsi.h
scsi: arm: Move the SCSI pointer to private command data
53c700: Stop clearing SCSI pointer fields
aacraid: Move the SCSI pointer to private command data
advansys: Move the SCSI pointer to private command data
aha1542: Remove a set-but-not-used array
aha152x: Move the SCSI pointer to private command data
bfa: Stop using the SCSI pointer
csio: Stop using the SCSI pointer
dc395x: Stop using the SCSI pointer
esp_scsi: Stop using the SCSI pointer
fdomain: Move the SCSI pointer to private command data
fnic: Fix a tracing statement
fnic: Stop using the SCSI pointer
hptiop: Stop using the SCSI pointer
imm: Move the SCSI pointer to private command data
iscsi: Stop using the SCSI pointer
initio: Stop using the SCSI pointer
libfc: Stop using the SCSI pointer
mac53c94: Fix a set-but-not-used compiler warning
mac53c94: Move the SCSI pointer to private command data
megaraid: Stop using the SCSI pointer
megasas: Stop using the SCSI pointer
mesh: Move the SCSI pointer to private command data
mvsas: Fix a set-but-not-used warning
mvumi: Stop using the SCSI pointer
nsp32: Stop using the SCSI pointer
nsp_cs: Move the SCSI pointer to private command data
sym53c500_cs: Move the SCSI pointer to private command data
ppa: Move the SCSI pointer to private command data
qla1280: Move the SCSI pointer to private command data
qla2xxx: Stop using the SCSI pointer
smartpqi: Stop using the SCSI pointer
sym53c8xx_2: Move the SCSI pointer to private command data
scsi: usb: Stop using the SCSI pointer
wd719x: Stop using the SCSI pointer
wdc33c93: Move the SCSI pointer to private command data
zalon: Stop using the SCSI pointer
scsi: core: Remove struct scsi_pointer from struct scsi_cmnd
drivers/infiniband/ulp/iser/iscsi_iser.c | 1 +
drivers/scsi/53c700.c | 2 -
drivers/scsi/NCR5380.c | 83 +++---
drivers/scsi/NCR5380.h | 8 +-
drivers/scsi/a2091.c | 25 +-
drivers/scsi/a3000.c | 25 +-
drivers/scsi/aacraid/aachba.c | 43 +--
drivers/scsi/aacraid/aacraid.h | 24 +-
drivers/scsi/aacraid/comminit.c | 2 +-
drivers/scsi/aacraid/linit.c | 21 +-
drivers/scsi/advansys.c | 22 +-
drivers/scsi/aha152x.c | 268 ++++++++++--------
drivers/scsi/aha1542.c | 3 +-
drivers/scsi/aha1740.c | 6 +-
drivers/scsi/arm/acornscsi.c | 28 +-
drivers/scsi/arm/{scsi.h => arm_scsi.h} | 37 ++-
drivers/scsi/arm/arxescsi.c | 6 +-
drivers/scsi/arm/cumana_1.c | 2 +-
drivers/scsi/arm/cumana_2.c | 8 +-
drivers/scsi/arm/eesox.c | 8 +-
drivers/scsi/arm/fas216.c | 36 ++-
drivers/scsi/arm/fas216.h | 1 +
drivers/scsi/arm/oak.c | 2 +-
drivers/scsi/arm/powertec.c | 8 +-
drivers/scsi/arm/queue.c | 6 +-
drivers/scsi/atari_scsi.c | 8 +-
drivers/scsi/be2iscsi/be_main.c | 3 +-
drivers/scsi/bfa/bfad_im.c | 27 +-
drivers/scsi/bfa/bfad_im.h | 16 ++
drivers/scsi/bnx2fc/bnx2fc.h | 10 +-
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 1 +
drivers/scsi/bnx2fc/bnx2fc_io.c | 20 +-
drivers/scsi/bnx2i/bnx2i_iscsi.c | 1 +
drivers/scsi/csiostor/csio_scsi.c | 20 +-
drivers/scsi/csiostor/csio_scsi.h | 10 +
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 1 +
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 1 +
drivers/scsi/dc395x.c | 3 -
drivers/scsi/dmx3191d.c | 2 +-
drivers/scsi/esp_scsi.c | 4 +-
drivers/scsi/esp_scsi.h | 3 +-
drivers/scsi/fcoe/fcoe.c | 1 +
drivers/scsi/fdomain.c | 70 +++--
drivers/scsi/fnic/fnic.h | 28 +-
drivers/scsi/fnic/fnic_main.c | 1 +
drivers/scsi/fnic/fnic_scsi.c | 289 ++++++++++----------
drivers/scsi/g_NCR5380.c | 7 +-
drivers/scsi/gvp11.c | 25 +-
drivers/scsi/hptiop.c | 1 +
drivers/scsi/hptiop.h | 4 +-
drivers/scsi/imm.c | 88 +++---
drivers/scsi/imm.h | 11 +
drivers/scsi/initio.c | 14 +-
drivers/scsi/initio.h | 9 +
drivers/scsi/ips.c | 50 ++--
drivers/scsi/iscsi_tcp.c | 1 +
drivers/scsi/libfc/fc_fcp.c | 26 +-
drivers/scsi/libiscsi.c | 22 +-
drivers/scsi/mac53c94.c | 27 +-
drivers/scsi/mac53c94.h | 11 +
drivers/scsi/mac_scsi.c | 8 +-
drivers/scsi/megaraid.c | 21 +-
drivers/scsi/megaraid.h | 15 +-
drivers/scsi/megaraid/megaraid_sas.h | 12 +
drivers/scsi/megaraid/megaraid_sas_base.c | 8 +-
drivers/scsi/megaraid/megaraid_sas_fusion.c | 15 +-
drivers/scsi/mesh.c | 20 +-
drivers/scsi/mesh.h | 11 +
drivers/scsi/mvme147.c | 16 +-
drivers/scsi/mvsas/mv_init.c | 7 +-
drivers/scsi/mvumi.c | 9 +-
drivers/scsi/mvumi.h | 9 +
drivers/scsi/ncr53c8xx.c | 22 +-
drivers/scsi/ncr53c8xx.h | 6 +
drivers/scsi/nsp32.c | 20 +-
drivers/scsi/nsp32.h | 9 +
drivers/scsi/pcmcia/aha152x_stub.c | 10 +-
drivers/scsi/pcmcia/nsp_cs.c | 252 +++++++++--------
drivers/scsi/pcmcia/nsp_cs.h | 8 +-
drivers/scsi/pcmcia/nsp_debug.c | 2 +-
drivers/scsi/pcmcia/qlogic_stub.c | 10 +-
drivers/scsi/pcmcia/sym53c500_cs.c | 53 ++--
drivers/scsi/ppa.c | 81 +++---
drivers/scsi/qedf/qedf.h | 11 +-
drivers/scsi/qedf/qedf_io.c | 16 +-
drivers/scsi/qedf/qedf_main.c | 3 +-
drivers/scsi/qedi/qedi_fw.c | 2 +-
drivers/scsi/qedi/qedi_iscsi.c | 1 +
drivers/scsi/qla1280.c | 21 +-
drivers/scsi/qla1280.h | 3 +-
drivers/scsi/qla2xxx/qla_def.h | 2 -
drivers/scsi/qla2xxx/qla_os.c | 13 +-
drivers/scsi/qla4xxx/ql4_def.h | 13 +-
drivers/scsi/qla4xxx/ql4_os.c | 13 +-
drivers/scsi/qlogicfas.c | 6 +-
drivers/scsi/qlogicfas408.c | 6 +-
drivers/scsi/scsi.h | 46 ----
drivers/scsi/sg.c | 8 +-
drivers/scsi/sgiwd93.c | 24 +-
drivers/scsi/smartpqi/smartpqi_init.c | 14 +-
drivers/scsi/sun3_scsi.c | 5 +-
drivers/scsi/sym53c8xx_2/sym_glue.c | 4 +-
drivers/scsi/wd33c93.c | 119 ++++----
drivers/scsi/wd33c93.h | 10 +
drivers/scsi/wd719x.c | 12 +-
drivers/scsi/wd719x.h | 1 +
drivers/scsi/zalon.c | 1 +
drivers/usb/image/microtek.c | 8 +-
drivers/usb/storage/debug.c | 1 -
drivers/usb/storage/uas.c | 43 ++-
include/scsi/libfc.h | 11 +
include/scsi/libiscsi.h | 12 +
include/scsi/scsi_cmnd.h | 14 +-
113 files changed, 1500 insertions(+), 1057 deletions(-)
rename drivers/scsi/arm/{scsi.h => arm_scsi.h} (75%)
delete mode 100644 drivers/scsi/scsi.h
next reply other threads:[~2022-02-08 17:25 UTC|newest]
Thread overview: 168+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 17:24 Bart Van Assche [this message]
2022-02-08 17:24 ` [PATCH v2 01/44] ips: Use true and false instead of TRUE and FALSE Bart Van Assche
2022-02-08 18:04 ` John Garry
2022-02-09 0:04 ` Bart Van Assche
2022-02-09 9:06 ` John Garry
2022-02-08 20:00 ` Himanshu Madhani
2022-02-09 7:23 ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 02/44] nsp_cs: " Bart Van Assche
2022-02-08 19:22 ` Himanshu Madhani
2022-02-09 7:23 ` Hannes Reinecke
2022-02-09 9:11 ` John Garry
2022-02-08 17:24 ` [PATCH v2 03/44] scsi: Remove drivers/scsi/scsi.h Bart Van Assche
2022-02-08 19:22 ` Himanshu Madhani
2022-02-09 7:26 ` Hannes Reinecke
2022-02-09 17:39 ` Bart Van Assche
2022-02-09 8:55 ` Johannes Thumshirn
2022-02-09 9:17 ` John Garry
2022-02-09 18:21 ` John Garry
2022-02-08 17:24 ` [PATCH v2 04/44] NCR5380: Remove the NCR5380_CMD_SIZE macro Bart Van Assche
2022-02-08 19:22 ` Himanshu Madhani
2022-02-08 22:14 ` Finn Thain
2022-02-09 7:27 ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 05/44] NCR5380: Move the SCSI pointer to private command data Bart Van Assche
2022-02-08 19:48 ` Himanshu Madhani
2022-02-08 22:22 ` Finn Thain
2022-02-09 0:10 ` Bart Van Assche
2022-02-09 7:29 ` Hannes Reinecke
2022-02-09 17:58 ` Bart Van Assche
2022-02-08 17:24 ` [PATCH v2 06/44] scsi: arm: Rename arm/scsi.h into arm/arm_scsi.h Bart Van Assche
2022-02-08 19:49 ` Himanshu Madhani
2022-02-09 7:30 ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 07/44] scsi: arm: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 7:32 ` Hannes Reinecke
2022-02-09 17:49 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 08/44] 53c700: Stop clearing SCSI pointer fields Bart Van Assche
2022-02-08 19:58 ` Himanshu Madhani
2022-02-09 7:32 ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 09/44] aacraid: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 7:34 ` Hannes Reinecke
2022-02-09 17:47 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 10/44] advansys: " Bart Van Assche
2022-02-08 17:24 ` [PATCH v2 11/44] aha1542: Remove a set-but-not-used array Bart Van Assche
2022-02-09 7:35 ` Hannes Reinecke
2022-02-09 17:50 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 12/44] aha152x: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 7:35 ` Hannes Reinecke
2022-02-09 17:57 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 13/44] bfa: Stop using the SCSI pointer Bart Van Assche
2022-02-09 7:40 ` Hannes Reinecke
2022-02-09 18:19 ` Bart Van Assche
2022-02-10 7:29 ` Hannes Reinecke
2022-02-09 18:00 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 14/44] csio: " Bart Van Assche
2022-02-09 7:41 ` Hannes Reinecke
2022-02-09 18:03 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 15/44] dc395x: " Bart Van Assche
2022-02-09 7:42 ` Hannes Reinecke
2022-02-09 18:03 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 16/44] esp_scsi: " Bart Van Assche
2022-02-09 7:45 ` Hannes Reinecke
2022-02-09 18:04 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 17/44] fdomain: Move the SCSI pointer to private command data Bart Van Assche
2022-02-08 20:35 ` Himanshu Madhani
2022-02-09 7:46 ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 18/44] fnic: Fix a tracing statement Bart Van Assche
2022-02-09 7:46 ` Hannes Reinecke
2022-02-09 18:05 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 19/44] fnic: Stop using the SCSI pointer Bart Van Assche
2022-02-09 7:56 ` Hannes Reinecke
2022-02-09 18:22 ` Bart Van Assche
2022-02-10 7:30 ` Hannes Reinecke
2022-02-09 18:17 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 20/44] hptiop: " Bart Van Assche
2022-02-09 7:57 ` Hannes Reinecke
2022-02-09 18:24 ` Bart Van Assche
2022-02-10 7:32 ` Hannes Reinecke
2022-02-09 18:18 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 21/44] imm: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 7:58 ` Hannes Reinecke
2022-02-09 18:27 ` Bart Van Assche
2022-02-10 7:42 ` Hannes Reinecke
2022-02-10 23:54 ` Bart Van Assche
2022-02-09 18:19 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 22/44] iscsi: Stop using the SCSI pointer Bart Van Assche
2022-02-09 7:59 ` Hannes Reinecke
2022-02-09 18:22 ` Himanshu Madhani
2022-02-09 19:55 ` Lee Duncan
2022-02-09 21:24 ` Mike Christie
2022-02-09 23:35 ` Chris Leech
2022-02-10 1:21 ` Bart Van Assche
2022-02-09 23:37 ` Chris Leech
2022-02-10 1:26 ` Bart Van Assche
2022-02-08 17:24 ` [PATCH v2 23/44] initio: " Bart Van Assche
2022-02-09 8:04 ` Hannes Reinecke
2022-02-09 18:24 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 24/44] libfc: " Bart Van Assche
2022-02-09 8:10 ` Hannes Reinecke
2022-02-09 18:33 ` Bart Van Assche
2022-02-09 18:28 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 25/44] mac53c94: Fix a set-but-not-used compiler warning Bart Van Assche
2022-02-09 8:10 ` Hannes Reinecke
2022-02-09 18:33 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 26/44] mac53c94: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 8:11 ` Hannes Reinecke
2022-02-09 18:35 ` Bart Van Assche
2022-02-10 7:52 ` Hannes Reinecke
2022-02-09 18:37 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 27/44] megaraid: Stop using the SCSI pointer Bart Van Assche
2022-02-09 8:14 ` Hannes Reinecke
2022-02-09 18:38 ` Bart Van Assche
2022-02-09 18:39 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 28/44] megasas: " Bart Van Assche
2022-02-09 8:16 ` Hannes Reinecke
2022-02-09 18:45 ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 29/44] mesh: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 8:49 ` Hannes Reinecke
2022-02-09 18:42 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 30/44] mvsas: Fix a set-but-not-used warning Bart Van Assche
2022-02-08 17:50 ` John Garry
2022-02-09 0:19 ` Bart Van Assche
2022-02-09 8:49 ` Hannes Reinecke
2022-02-09 18:43 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 31/44] mvumi: Stop using the SCSI pointer Bart Van Assche
2022-02-09 8:18 ` Hannes Reinecke
2022-02-09 18:46 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 32/44] nsp32: " Bart Van Assche
2022-02-09 8:18 ` Hannes Reinecke
2022-02-09 8:19 ` Hannes Reinecke
2022-02-09 18:48 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 33/44] nsp_cs: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 8:20 ` Hannes Reinecke
2022-02-09 18:50 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 34/44] sym53c500_cs: " Bart Van Assche
2022-02-09 8:21 ` Hannes Reinecke
2022-02-09 18:56 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 35/44] ppa: " Bart Van Assche
2022-02-09 8:22 ` Hannes Reinecke
2022-02-09 18:56 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 36/44] qla1280: " Bart Van Assche
2022-02-09 8:22 ` Hannes Reinecke
2022-02-09 18:58 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 37/44] qla2xxx: Stop using the SCSI pointer Bart Van Assche
2022-02-08 18:38 ` Himanshu Madhani
2022-02-09 8:24 ` Hannes Reinecke
2022-02-09 10:11 ` Daniel Wagner
2022-02-08 17:25 ` [PATCH v2 38/44] smartpqi: " Bart Van Assche
2022-02-09 8:33 ` Hannes Reinecke
2022-02-09 18:59 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 39/44] sym53c8xx_2: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 8:34 ` Hannes Reinecke
2022-02-09 19:10 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 40/44] scsi: usb: Stop using the SCSI pointer Bart Van Assche
2022-02-09 8:35 ` Hannes Reinecke
2022-02-09 19:01 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 41/44] wd719x: " Bart Van Assche
2022-02-09 8:35 ` Hannes Reinecke
2022-02-09 19:04 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 42/44] wdc33c93: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09 8:36 ` Hannes Reinecke
2022-02-09 19:10 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 43/44] zalon: Stop using the SCSI pointer Bart Van Assche
2022-02-09 8:36 ` Hannes Reinecke
2022-02-09 19:11 ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 44/44] scsi: core: Remove struct scsi_pointer from struct scsi_cmnd Bart Van Assche
2022-02-08 17:54 ` John Garry
2022-02-09 0:24 ` Bart Van Assche
2022-02-08 19:22 ` Himanshu Madhani
2022-02-09 8:38 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208172514.3481-1-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox