From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
Hannes Reinecke <hare@suse.de>,
HighPoint Linux Team <linux@highpoint-tech.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: [PATCH v4 24/50] scsi: hptiop: Stop using the SCSI pointer
Date: Wed, 16 Feb 2022 13:02:07 -0800 [thread overview]
Message-ID: <20220216210233.28774-25-bvanassche@acm.org> (raw)
In-Reply-To: <20220216210233.28774-1-bvanassche@acm.org>
Set .cmd_size in the SCSI host template instead of using the SCSI pointer
from struct scsi_cmnd. This patch prepares for removal of the SCSI pointer
from struct scsi_cmnd.
Rename hpt_scsi_pointer into hpt_cmd_priv because that data structure is
not related to struct scsi_pointer.
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/hptiop.c | 1 +
drivers/scsi/hptiop.h | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
index d04245e379d7..f18b770626e6 100644
--- a/drivers/scsi/hptiop.c
+++ b/drivers/scsi/hptiop.c
@@ -1174,6 +1174,7 @@ static struct scsi_host_template driver_template = {
.slave_configure = hptiop_slave_config,
.this_id = -1,
.change_queue_depth = hptiop_adjust_disk_queue_depth,
+ .cmd_size = sizeof(struct hpt_cmd_priv),
};
static int hptiop_internal_memalloc_itl(struct hptiop_hba *hba)
diff --git a/drivers/scsi/hptiop.h b/drivers/scsi/hptiop.h
index 35184c2008af..363d5a16243f 100644
--- a/drivers/scsi/hptiop.h
+++ b/drivers/scsi/hptiop.h
@@ -251,13 +251,13 @@ struct hptiop_request {
int index;
};
-struct hpt_scsi_pointer {
+struct hpt_cmd_priv {
int mapped;
int sgcnt;
dma_addr_t dma_handle;
};
-#define HPT_SCP(scp) ((struct hpt_scsi_pointer *)&(scp)->SCp)
+#define HPT_SCP(scp) ((struct hpt_cmd_priv *)scsi_cmd_priv(scp))
enum hptiop_family {
UNKNOWN_BASED_IOP,
next prev parent reply other threads:[~2022-02-16 21:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 21:01 [PATCH v4 00/50] Remove the SCSI pointer from struct scsi_cmnd Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 01/50] scsi: ips: Remove an unreachable statement Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 02/50] scsi: ips: Change the return type of ips_release() into 'void' Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 03/50] scsi: ips: Use true and false instead of TRUE and FALSE Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 04/50] scsi: nsp_cs: Change the return type of two functions into 'void' Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 05/50] scsi: nsp_cs: Use true and false instead of TRUE and FALSE Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 06/50] scsi: Remove drivers/scsi/scsi.h Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 07/50] scsi: NCR5380: Remove the NCR5380_CMD_SIZE macro Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 08/50] scsi: NCR5380: Introduce the NCR5380_cmd_priv() function Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 09/50] scsi: NCR5380: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 10/50] scsi: arm: Rename arm/scsi.h into arm/arm_scsi.h Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 11/50] scsi: arm: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 12/50] scsi: 53c700: Stop clearing SCSI pointer fields Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 13/50] scsi: aacraid: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 14/50] scsi: advansys: " Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 15/50] scsi: aha1542: Remove a set-but-not-used array Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 16/50] scsi: aha152x: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 17/50] scsi: bfa: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 18/50] scsi: csio: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 19/50] scsi: dc395x: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 20/50] scsi: esp_scsi: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 21/50] scsi: fdomain: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 22/50] scsi: fnic: Fix a tracing statement Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 23/50] scsi: fnic: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` Bart Van Assche [this message]
2022-02-16 21:02 ` [PATCH v4 25/50] scsi: imm: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 26/50] scsi: iscsi: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 27/50] scsi: initio: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 28/50] scsi: libfc: " Bart Van Assche
2022-02-17 7:05 ` Hannes Reinecke
2022-02-16 21:02 ` [PATCH v4 29/50] scsi: bnx2fc: " Bart Van Assche
2022-02-17 7:06 ` Hannes Reinecke
2022-02-16 21:02 ` [PATCH v4 30/50] scsi: qedf: " Bart Van Assche
2022-02-17 7:06 ` Hannes Reinecke
2022-02-16 21:02 ` [PATCH v4 31/50] scsi: mac53c94: Fix a set-but-not-used compiler warning Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 32/50] scsi: mac53c94: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 33/50] scsi: megaraid: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 34/50] scsi: megasas: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 35/50] scsi: mesh: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 36/50] scsi: mvsas: Fix a set-but-not-used warning Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 37/50] scsi: mvumi: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 38/50] scsi: nsp32: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 39/50] scsi: nsp_cs: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 40/50] scsi: sym53c500_cs: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 41/50] scsi: ppa: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 42/50] scsi: qla1280: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 43/50] scsi: qla2xxx: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 44/50] scsi: smartpqi: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 45/50] scsi: sym53c8xx_2: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 46/50] scsi: usb: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 47/50] scsi: wd719x: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 48/50] scsi: wd33c93: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 49/50] scsi: zalon: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 50/50] scsi: core: Remove struct scsi_pointer from struct scsi_cmnd Bart Van Assche
2022-02-18 0:45 ` [PATCH v4 00/50] Remove the SCSI pointer " Finn Thain
2022-02-18 19:43 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216210233.28774-25-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@highpoint-tech.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox