From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
Finn Thain <fthain@linux-m68k.org>,
Hannes Reinecke <hare@suse.de>,
Finn Thain <fthain@telegraphics.com.au>,
Hannes Reinecke <hare@suse.com>,
Ondrej Zary <linux@rainbow-software.org>,
Michael Schmitz <schmitzmic@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Russell King <linux@armlinux.org.uk>
Subject: [PATCH v4 07/50] scsi: NCR5380: Remove the NCR5380_CMD_SIZE macro
Date: Wed, 16 Feb 2022 13:01:50 -0800 [thread overview]
Message-ID: <20220216210233.28774-8-bvanassche@acm.org> (raw)
In-Reply-To: <20220216210233.28774-1-bvanassche@acm.org>
This makes it easier to find users of the NCR5380_cmd data structure with
'grep'.
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Acked-by: Finn Thain <fthain@linux-m68k.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: Finn Thain <fthain@telegraphics.com.au>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Ondrej Zary <linux@rainbow-software.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/NCR5380.h | 2 --
drivers/scsi/arm/cumana_1.c | 2 +-
drivers/scsi/arm/oak.c | 2 +-
drivers/scsi/atari_scsi.c | 2 +-
drivers/scsi/dmx3191d.c | 2 +-
drivers/scsi/g_NCR5380.c | 2 +-
drivers/scsi/mac_scsi.c | 2 +-
drivers/scsi/sun3_scsi.c | 2 +-
8 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/NCR5380.h b/drivers/scsi/NCR5380.h
index 8a3b41932288..845bd2423e66 100644
--- a/drivers/scsi/NCR5380.h
+++ b/drivers/scsi/NCR5380.h
@@ -230,8 +230,6 @@ struct NCR5380_cmd {
struct list_head list;
};
-#define NCR5380_CMD_SIZE (sizeof(struct NCR5380_cmd))
-
#define NCR5380_PIO_CHUNK_SIZE 256
/* Time limit (ms) to poll registers when IRQs are disabled, e.g. during PDMA */
diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c
index 3fd944374631..5d4f67ba74c0 100644
--- a/drivers/scsi/arm/cumana_1.c
+++ b/drivers/scsi/arm/cumana_1.c
@@ -223,7 +223,7 @@ static struct scsi_host_template cumanascsi_template = {
.sg_tablesize = SG_ALL,
.cmd_per_lun = 2,
.proc_name = "CumanaSCSI-1",
- .cmd_size = NCR5380_CMD_SIZE,
+ .cmd_size = sizeof(struct NCR5380_cmd),
.max_sectors = 128,
.dma_boundary = PAGE_SIZE - 1,
};
diff --git a/drivers/scsi/arm/oak.c b/drivers/scsi/arm/oak.c
index 78f33d57c3e8..f18a0620c808 100644
--- a/drivers/scsi/arm/oak.c
+++ b/drivers/scsi/arm/oak.c
@@ -113,7 +113,7 @@ static struct scsi_host_template oakscsi_template = {
.cmd_per_lun = 2,
.dma_boundary = PAGE_SIZE - 1,
.proc_name = "oakscsi",
- .cmd_size = NCR5380_CMD_SIZE,
+ .cmd_size = sizeof(struct NCR5380_cmd),
.max_sectors = 128,
};
diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c
index 95d7a3586083..e9d0d99abc86 100644
--- a/drivers/scsi/atari_scsi.c
+++ b/drivers/scsi/atari_scsi.c
@@ -711,7 +711,7 @@ static struct scsi_host_template atari_scsi_template = {
.this_id = 7,
.cmd_per_lun = 2,
.dma_boundary = PAGE_SIZE - 1,
- .cmd_size = NCR5380_CMD_SIZE,
+ .cmd_size = sizeof(struct NCR5380_cmd),
};
static int __init atari_scsi_probe(struct platform_device *pdev)
diff --git a/drivers/scsi/dmx3191d.c b/drivers/scsi/dmx3191d.c
index 6df60b31ecb0..a171ce6b70b2 100644
--- a/drivers/scsi/dmx3191d.c
+++ b/drivers/scsi/dmx3191d.c
@@ -52,7 +52,7 @@ static struct scsi_host_template dmx3191d_driver_template = {
.sg_tablesize = SG_ALL,
.cmd_per_lun = 2,
.dma_boundary = PAGE_SIZE - 1,
- .cmd_size = NCR5380_CMD_SIZE,
+ .cmd_size = sizeof(struct NCR5380_cmd),
};
static int dmx3191d_probe_one(struct pci_dev *pdev,
diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
index 7ba3c9312731..5923f86a384e 100644
--- a/drivers/scsi/g_NCR5380.c
+++ b/drivers/scsi/g_NCR5380.c
@@ -702,7 +702,7 @@ static struct scsi_host_template driver_template = {
.sg_tablesize = SG_ALL,
.cmd_per_lun = 2,
.dma_boundary = PAGE_SIZE - 1,
- .cmd_size = NCR5380_CMD_SIZE,
+ .cmd_size = sizeof(struct NCR5380_cmd),
.max_sectors = 128,
};
diff --git a/drivers/scsi/mac_scsi.c b/drivers/scsi/mac_scsi.c
index 5c808fbc6ce2..71d493a0bb43 100644
--- a/drivers/scsi/mac_scsi.c
+++ b/drivers/scsi/mac_scsi.c
@@ -434,7 +434,7 @@ static struct scsi_host_template mac_scsi_template = {
.sg_tablesize = 1,
.cmd_per_lun = 2,
.dma_boundary = PAGE_SIZE - 1,
- .cmd_size = NCR5380_CMD_SIZE,
+ .cmd_size = sizeof(struct NCR5380_cmd),
.max_sectors = 128,
};
diff --git a/drivers/scsi/sun3_scsi.c b/drivers/scsi/sun3_scsi.c
index f7f724a3ff1d..82a253270c3b 100644
--- a/drivers/scsi/sun3_scsi.c
+++ b/drivers/scsi/sun3_scsi.c
@@ -505,7 +505,7 @@ static struct scsi_host_template sun3_scsi_template = {
.sg_tablesize = 1,
.cmd_per_lun = 2,
.dma_boundary = PAGE_SIZE - 1,
- .cmd_size = NCR5380_CMD_SIZE,
+ .cmd_size = sizeof(struct NCR5380_cmd),
};
static int __init sun3_scsi_probe(struct platform_device *pdev)
next prev parent reply other threads:[~2022-02-16 21:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 21:01 [PATCH v4 00/50] Remove the SCSI pointer from struct scsi_cmnd Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 01/50] scsi: ips: Remove an unreachable statement Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 02/50] scsi: ips: Change the return type of ips_release() into 'void' Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 03/50] scsi: ips: Use true and false instead of TRUE and FALSE Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 04/50] scsi: nsp_cs: Change the return type of two functions into 'void' Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 05/50] scsi: nsp_cs: Use true and false instead of TRUE and FALSE Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 06/50] scsi: Remove drivers/scsi/scsi.h Bart Van Assche
2022-02-16 21:01 ` Bart Van Assche [this message]
2022-02-16 21:01 ` [PATCH v4 08/50] scsi: NCR5380: Introduce the NCR5380_cmd_priv() function Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 09/50] scsi: NCR5380: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 10/50] scsi: arm: Rename arm/scsi.h into arm/arm_scsi.h Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 11/50] scsi: arm: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 12/50] scsi: 53c700: Stop clearing SCSI pointer fields Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 13/50] scsi: aacraid: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 14/50] scsi: advansys: " Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 15/50] scsi: aha1542: Remove a set-but-not-used array Bart Van Assche
2022-02-16 21:01 ` [PATCH v4 16/50] scsi: aha152x: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 17/50] scsi: bfa: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 18/50] scsi: csio: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 19/50] scsi: dc395x: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 20/50] scsi: esp_scsi: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 21/50] scsi: fdomain: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 22/50] scsi: fnic: Fix a tracing statement Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 23/50] scsi: fnic: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 24/50] scsi: hptiop: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 25/50] scsi: imm: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 26/50] scsi: iscsi: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 27/50] scsi: initio: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 28/50] scsi: libfc: " Bart Van Assche
2022-02-17 7:05 ` Hannes Reinecke
2022-02-16 21:02 ` [PATCH v4 29/50] scsi: bnx2fc: " Bart Van Assche
2022-02-17 7:06 ` Hannes Reinecke
2022-02-16 21:02 ` [PATCH v4 30/50] scsi: qedf: " Bart Van Assche
2022-02-17 7:06 ` Hannes Reinecke
2022-02-16 21:02 ` [PATCH v4 31/50] scsi: mac53c94: Fix a set-but-not-used compiler warning Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 32/50] scsi: mac53c94: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 33/50] scsi: megaraid: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 34/50] scsi: megasas: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 35/50] scsi: mesh: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 36/50] scsi: mvsas: Fix a set-but-not-used warning Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 37/50] scsi: mvumi: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 38/50] scsi: nsp32: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 39/50] scsi: nsp_cs: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 40/50] scsi: sym53c500_cs: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 41/50] scsi: ppa: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 42/50] scsi: qla1280: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 43/50] scsi: qla2xxx: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 44/50] scsi: smartpqi: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 45/50] scsi: sym53c8xx_2: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 46/50] scsi: usb: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 47/50] scsi: wd719x: " Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 48/50] scsi: wd33c93: Move the SCSI pointer to private command data Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 49/50] scsi: zalon: Stop using the SCSI pointer Bart Van Assche
2022-02-16 21:02 ` [PATCH v4 50/50] scsi: core: Remove struct scsi_pointer from struct scsi_cmnd Bart Van Assche
2022-02-18 0:45 ` [PATCH v4 00/50] Remove the SCSI pointer " Finn Thain
2022-02-18 19:43 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216210233.28774-8-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=fthain@linux-m68k.org \
--cc=fthain@telegraphics.com.au \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox