Re: [PATCH 3/8] scsi: sd_zbc: Verify that the zone size is a power of two

Bart Van Assche
2022-04-18T16:56:35Z

On 4/17/22 16:09, Damien Le Moal wrote:
> On 4/16/22 05:17, Bart Van Assche wrote:
>> The following check in sd_zbc_cmnd_checks() can only work correctly if
>> the zone size is a power of two:
>>
>> if (sector & (sd_zbc_zone_sectors(sdkp) - 1))
>> /* Unaligned request */
>> return BLK_STS_IOERR;
>>
>> Hence this patch that verifies that the zone size is a power of two.
>
> Note that this is already checked in blk_revalidate_disk_zones(), but it
> does not hurt to add the check.

If the block layer would be modified such that support is added for zones with
a size that is not a power of two I think we will really need this check.

Thanks,

Bart.