From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Eric Biggers <ebiggers@google.com>
Subject: [PATCH v3 23/28] scsi: ufs: Remove unnecessary ufshcd-crypto.h include directives
Date: Tue, 19 Apr 2022 15:58:06 -0700 [thread overview]
Message-ID: <20220419225811.4127248-24-bvanassche@acm.org> (raw)
In-Reply-To: <20220419225811.4127248-1-bvanassche@acm.org>
ufshcd-crypto.h declares functions that must only be called by the UFS
core. Hence remove the #include "ufshcd-crypto.h" directive from UFS
drivers.
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/ufs/ufs-mediatek.c | 1 -
drivers/scsi/ufs/ufs-qcom-ice.c | 1 -
drivers/scsi/ufs/ufs-qcom.h | 1 +
3 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index d19b35495302..84ccb5258736 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -19,7 +19,6 @@
#include <linux/soc/mediatek/mtk_sip_svc.h>
#include "ufshcd.h"
-#include "ufshcd-crypto.h"
#include "ufshcd-pltfrm.h"
#include "ufs_quirks.h"
#include "unipro.h"
diff --git a/drivers/scsi/ufs/ufs-qcom-ice.c b/drivers/scsi/ufs/ufs-qcom-ice.c
index bbb0ad7590ec..921d6a93b653 100644
--- a/drivers/scsi/ufs/ufs-qcom-ice.c
+++ b/drivers/scsi/ufs/ufs-qcom-ice.c
@@ -9,7 +9,6 @@
#include <linux/platform_device.h>
#include <linux/qcom_scm.h>
-#include "ufshcd-crypto.h"
#include "ufs-qcom.h"
#define AES_256_XTS_KEY_SIZE 64
diff --git a/drivers/scsi/ufs/ufs-qcom.h b/drivers/scsi/ufs/ufs-qcom.h
index 51570224a6e2..771bc95d02c7 100644
--- a/drivers/scsi/ufs/ufs-qcom.h
+++ b/drivers/scsi/ufs/ufs-qcom.h
@@ -7,6 +7,7 @@
#include <linux/reset-controller.h>
#include <linux/reset.h>
+#include "ufshcd.h"
#define MAX_UFS_QCOM_HOSTS 1
#define MAX_U32 (~(u32)0)
next prev parent reply other threads:[~2022-04-19 22:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 22:57 [PATCH v3 00/28] Split the ufshcd.h header file Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 01/28] scsi: ufs: Fix a spelling error in a source code comment Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 02/28] scsi: ufs: Declare ufshcd_wait_for_register() static Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 03/28] scsi: ufs: Remove superfluous boolean conversions Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 04/28] scsi: ufs: Simplify statements that return a boolean Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 05/28] scsi: ufs: Remove ufshcd_lrb.sense_bufflen Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 06/28] scsi: ufs: Remove ufshcd_lrb.sense_buffer Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 07/28] scsi: ufs: Use get_unaligned_be16() instead of be16_to_cpup() Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 08/28] scsi: ufs: Remove the UFS_FIX() and END_FIX() macros Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 09/28] scsi: ufs: Rename struct ufs_dev_fix into ufs_dev_quirk Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 10/28] scsi: ufs: Declare the quirks array const Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 11/28] scsi: ufs: Invert the return value of ufshcd_is_hba_active() Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 12/28] scsi: ufs: Remove unused constants and code Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 13/28] scsi: ufs: Switch to aggregate initialization Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 14/28] scsi: ufs: Make the config_scaling_param calls type safe Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 15/28] scsi: ufs: Remove the driver version Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 16/28] scsi: ufs: Rename sdev_ufs_device into ufs_device_wlun Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 17/28] scsi: ufs: Use an SPDX license identifier in the Kconfig file Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 18/28] scsi: ufs: Remove paths from source code comments Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 19/28] scsi: ufs: Remove the TRUE and FALSE definitions Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 20/28] scsi: ufs: Remove locking from around single register writes Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 21/28] scsi: ufs: Introduce ufshcd_clkgate_delay_set() Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 22/28] scsi: ufs: qcom: Fix ufs_qcom_resume() Bart Van Assche
2022-04-19 22:58 ` Bart Van Assche [this message]
2022-04-19 22:58 ` [PATCH v3 24/28] scsi: ufs: Fix kernel-doc syntax in ufshcd.h Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 25/28] scsi: ufs: Minimize #include directives Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 26/28] scsi: ufs: Split the ufshcd.h header file Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 27/28] scsi: ufs: Move the struct ufs_ref_clk definition Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 28/28] scsi: ufs: Move the ufs_is_valid_unit_desc_lun() definition Bart Van Assche
2022-04-25 20:58 ` [PATCH v3 00/28] Split the ufshcd.h header file Bean Huo
2022-04-26 2:43 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419225811.4127248-24-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).