linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v3 28/28] scsi: ufs: Move the ufs_is_valid_unit_desc_lun() definition
Date: Tue, 19 Apr 2022 15:58:11 -0700	[thread overview]
Message-ID: <20220419225811.4127248-29-bvanassche@acm.org> (raw)
In-Reply-To: <20220419225811.4127248-1-bvanassche@acm.org>

Move the definition of this function from a public into a private header
file since it is only used inside the UFS core.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/scsi/ufs/ufs.h         | 19 -------------------
 drivers/scsi/ufs/ufshcd-priv.h | 19 +++++++++++++++++++
 2 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index f52173b8ad96..1bba3fead2ce 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -620,23 +620,4 @@ enum ufs_trace_tsf_t {
 	UFS_TSF_CDB, UFS_TSF_OSF, UFS_TSF_TM_INPUT, UFS_TSF_TM_OUTPUT
 };
 
-/**
- * ufs_is_valid_unit_desc_lun - checks if the given LUN has a unit descriptor
- * @dev_info: pointer of instance of struct ufs_dev_info
- * @lun: LU number to check
- * @return: true if the lun has a matching unit descriptor, false otherwise
- */
-static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info,
-		u8 lun, u8 param_offset)
-{
-	if (!dev_info || !dev_info->max_lu_supported) {
-		pr_err("Max General LU supported by UFS isn't initialized\n");
-		return false;
-	}
-	/* WB is available only for the logical unit from 0 to 7 */
-	if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)
-		return lun < UFS_UPIU_MAX_WB_LUN_ID;
-	return lun == UFS_UPIU_RPMB_WLUN || (lun < dev_info->max_lu_supported);
-}
-
 #endif /* End of Header */
diff --git a/drivers/scsi/ufs/ufshcd-priv.h b/drivers/scsi/ufs/ufshcd-priv.h
index 3fa8ab94e4e1..38bc77d3dbbd 100644
--- a/drivers/scsi/ufs/ufshcd-priv.h
+++ b/drivers/scsi/ufs/ufshcd-priv.h
@@ -276,4 +276,23 @@ static inline int ufshcd_rpm_put(struct ufs_hba *hba)
 	return pm_runtime_put(&hba->ufs_device_wlun->sdev_gendev);
 }
 
+/**
+ * ufs_is_valid_unit_desc_lun - checks if the given LUN has a unit descriptor
+ * @dev_info: pointer of instance of struct ufs_dev_info
+ * @lun: LU number to check
+ * @return: true if the lun has a matching unit descriptor, false otherwise
+ */
+static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info,
+		u8 lun, u8 param_offset)
+{
+	if (!dev_info || !dev_info->max_lu_supported) {
+		pr_err("Max General LU supported by UFS isn't initialized\n");
+		return false;
+	}
+	/* WB is available only for the logical unit from 0 to 7 */
+	if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)
+		return lun < UFS_UPIU_MAX_WB_LUN_ID;
+	return lun == UFS_UPIU_RPMB_WLUN || (lun < dev_info->max_lu_supported);
+}
+
 #endif /* _UFSHCD_PRIV_H_ */

  parent reply	other threads:[~2022-04-19 22:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 22:57 [PATCH v3 00/28] Split the ufshcd.h header file Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 01/28] scsi: ufs: Fix a spelling error in a source code comment Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 02/28] scsi: ufs: Declare ufshcd_wait_for_register() static Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 03/28] scsi: ufs: Remove superfluous boolean conversions Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 04/28] scsi: ufs: Simplify statements that return a boolean Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 05/28] scsi: ufs: Remove ufshcd_lrb.sense_bufflen Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 06/28] scsi: ufs: Remove ufshcd_lrb.sense_buffer Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 07/28] scsi: ufs: Use get_unaligned_be16() instead of be16_to_cpup() Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 08/28] scsi: ufs: Remove the UFS_FIX() and END_FIX() macros Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 09/28] scsi: ufs: Rename struct ufs_dev_fix into ufs_dev_quirk Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 10/28] scsi: ufs: Declare the quirks array const Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 11/28] scsi: ufs: Invert the return value of ufshcd_is_hba_active() Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 12/28] scsi: ufs: Remove unused constants and code Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 13/28] scsi: ufs: Switch to aggregate initialization Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 14/28] scsi: ufs: Make the config_scaling_param calls type safe Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 15/28] scsi: ufs: Remove the driver version Bart Van Assche
2022-04-19 22:57 ` [PATCH v3 16/28] scsi: ufs: Rename sdev_ufs_device into ufs_device_wlun Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 17/28] scsi: ufs: Use an SPDX license identifier in the Kconfig file Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 18/28] scsi: ufs: Remove paths from source code comments Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 19/28] scsi: ufs: Remove the TRUE and FALSE definitions Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 20/28] scsi: ufs: Remove locking from around single register writes Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 21/28] scsi: ufs: Introduce ufshcd_clkgate_delay_set() Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 22/28] scsi: ufs: qcom: Fix ufs_qcom_resume() Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 23/28] scsi: ufs: Remove unnecessary ufshcd-crypto.h include directives Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 24/28] scsi: ufs: Fix kernel-doc syntax in ufshcd.h Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 25/28] scsi: ufs: Minimize #include directives Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 26/28] scsi: ufs: Split the ufshcd.h header file Bart Van Assche
2022-04-19 22:58 ` [PATCH v3 27/28] scsi: ufs: Move the struct ufs_ref_clk definition Bart Van Assche
2022-04-19 22:58 ` Bart Van Assche [this message]
2022-04-25 20:58 ` [PATCH v3 00/28] Split the ufshcd.h header file Bean Huo
2022-04-26  2:43 ` Martin K. Petersen
2022-05-03  0:51 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220419225811.4127248-29-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=adrian.hunter@intel.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).