Re: [PATCH 13/24] aic7xxx: make BUILD_SCSIID() a function

Hannes Reinecke
2022-05-03T14:18:54Z

On 5/3/22 07:12, Christoph Hellwig wrote:
>> +{
>> + unsigned int scsiid =
>> + ((sdev->id << TID_SHIFT) & TID) |
>> + ((sdev->channel == 0) ? ahc->our_id : ahc->our_id_b) |
>> + (sdev->channel == 0) ? 0 : TWIN_CHNLB;
>> + return scsiid;
>
> This still look weird. Why not:
>
> unsigned int scsiid = (sdev->id << TID_SHIFT) & TID);
>
> if (sdev->channel == 0) {
> scsiid |= ahc->our_id;
> else
> scsiid |= ahc->our_id_b | TWIN_CHNLB;
> return scsiid;
>
> ?
Yeah, kbuild had been complaining, too.

Will be fixing it up.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer