From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79154C433EF for ; Tue, 3 May 2022 14:33:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237091AbiECOhC (ORCPT ); Tue, 3 May 2022 10:37:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237086AbiECOhB (ORCPT ); Tue, 3 May 2022 10:37:01 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEB1731DEC for ; Tue, 3 May 2022 07:33:28 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4A5F967373; Tue, 3 May 2022 16:33:25 +0200 (CEST) Date: Tue, 3 May 2022 16:33:25 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: "Martin K. Petersen" , Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org, Hannes Reinecke Subject: Re: [PATCH 10/11] fas216: Rework device reset to not rely on SCSI command pointer Message-ID: <20220503143325.GH24492@lst.de> References: <20220502215416.5351-1-hare@suse.de> <20220502215416.5351-11-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220502215416.5351-11-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Eww, the function pointer abuse in this drive is rather gross. But the changes looks ok to me: Reviewed-by: Christoph Hellwig