* [PATCH] scsi: qedf: remove redundant variable op
@ 2022-05-17 9:25 Colin Ian King
2022-05-18 1:20 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-05-17 9:25 UTC (permalink / raw)
To: Saurav Kashyap, Javed Hasan, GR-QLogic-Storage-Upstream,
James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
The variable op is assigned a value and is never read. The variable
is not used and is redundant, remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/scsi/qedf/qedf_io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
index 2ec1f710fd1d..e57cc22453d0 100644
--- a/drivers/scsi/qedf/qedf_io.c
+++ b/drivers/scsi/qedf/qedf_io.c
@@ -804,7 +804,6 @@ static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req,
struct qedf_io_log *io_log;
struct scsi_cmnd *sc_cmd = io_req->sc_cmd;
unsigned long flags;
- uint8_t op;
spin_lock_irqsave(&qedf->io_trace_lock, flags);
@@ -813,7 +812,7 @@ static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req,
io_log->task_id = io_req->xid;
io_log->port_id = fcport->rdata->ids.port_id;
io_log->lun = sc_cmd->device->lun;
- io_log->op = op = sc_cmd->cmnd[0];
+ io_log->op = sc_cmd->cmnd[0];
io_log->lba[0] = sc_cmd->cmnd[2];
io_log->lba[1] = sc_cmd->cmnd[3];
io_log->lba[2] = sc_cmd->cmnd[4];
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedf: remove redundant variable op
2022-05-17 9:25 [PATCH] scsi: qedf: remove redundant variable op Colin Ian King
@ 2022-05-18 1:20 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-05-18 1:20 UTC (permalink / raw)
To: Colin Ian King
Cc: Saurav Kashyap, Javed Hasan, GR-QLogic-Storage-Upstream,
James E . J . Bottomley, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Colin,
> The variable op is assigned a value and is never read. The variable
> is not used and is redundant, remove it.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedf: remove redundant variable op
2022-05-17 9:25 [PATCH] scsi: qedf: remove redundant variable op Colin Ian King
2022-05-18 1:20 ` Martin K. Petersen
@ 2022-05-20 1:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-05-20 1:09 UTC (permalink / raw)
To: linux-scsi, James E . J . Bottomley, Javed Hasan, Saurav Kashyap,
Colin Ian King, GR-QLogic-Storage-Upstream
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Tue, 17 May 2022 10:25:18 +0100, Colin Ian King wrote:
> The variable op is assigned a value and is never read. The variable
> is not used and is redundant, remove it.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: qedf: remove redundant variable op
https://git.kernel.org/mkp/scsi/c/fc65df48c88e
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-20 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-17 9:25 [PATCH] scsi: qedf: remove redundant variable op Colin Ian King
2022-05-18 1:20 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox