From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F426C433EF for ; Tue, 24 May 2022 08:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232694AbiEXIgm (ORCPT ); Tue, 24 May 2022 04:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232377AbiEXIgk (ORCPT ); Tue, 24 May 2022 04:36:40 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1490714D16; Tue, 24 May 2022 01:36:39 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6DDB668AFE; Tue, 24 May 2022 10:36:35 +0200 (CEST) Date: Tue, 24 May 2022 10:36:35 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" , James Bottomley , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/2] block: document BLK_STS_AGAIN usage Message-ID: <20220524083635.GA27749@lst.de> References: <20220524055631.85480-1-hare@suse.de> <20220524055631.85480-2-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524055631.85480-2-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Tue, May 24, 2022 at 07:56:30AM +0200, Hannes Reinecke wrote: > BLK_STS_AGAIN should only be used if RQF_NOWAIT is set and the bio > would block. So we'd better document that to avoid accidental misuse. Looks good: Reviewed-by: Christoph Hellwig given that nothing in patch 2 depends on this it would be good to just get this into the block tree ASAP.